Golom contest - immeas's results

An NFT marketplace that offers the lowest industry fee, a publicly available order-book along with analytical tools.

General Information

Platform: Code4rena

Start Date: 26/07/2022

Pot Size: $75,000 USDC

Total HM: 29

Participants: 179

Period: 6 days

Judge: LSDan

Total Solo HM: 6

Id: 148

League: ETH

Golom

Findings Distribution

Researcher Performance

Rank: 177/179

Findings: 1

Award: $0.00

🌟 Selected for report: 0

🚀 Solo Findings: 0

Lines of code

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L154

Vulnerability details

Impact

Usage of the deprecated .transfer() can cause the transaction to fail if either of the involved parties needs more than 2300 gas to receive the payment .

Proof of Concept

Similar issues can be found in multiple previous audits and also a detailed explanation here: https://consensys.net/diligence/blog/2019/09/stop-using-soliditys-transfer-now/

use call() instead:

(bool success, ) = payable(payAddress).call{payAmt}(""); require(success, "Transfer failed.");

#0 - KenzoAgada

2022-08-03T14:22:13Z

Duplicate of #343

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter