Juicebox V2 contest - kaden's results

• Use do while loop instead of for loop since guaranteed to run at least once, e.g.
  • https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/JBDirectory.sol#L275

uint256 _i;
do {
  for (uint256 _j = _i + 1; _j < _terminals.length; _j++)
    if (_terminals[_i] == _terminals[_j]) revert DUPLICATE_TERMINALS();
  
  unchecked {
    ++_i;
  }
} while (_i < _terminals.length);

• Unnecessary mem var
  • Should instead just use e.g. _groupedSplits.length directly in the for loop
  • https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/JBSplitsStore.sol#L162
  • https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/abstract/JBPayoutRedemptionPaymentTerminal.sol#L591
  • https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/abstract/JBPayoutRedemptionPaymentTerminal.sol#L1393
• Use assembly selfbalance() instead of address(this).balance
  • https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/JBETHERC20SplitsPayer.sol#L152
  • https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/JBETHERC20ProjectPayer.sol#L162
• Use efficient iterator incrementation
  • Seen throughout the contracts
  • Use ++i instead of i++
  • Use unchecked block e.g.

for (uint256 i; i < arr.length;) {
  ...
  unchecked {
    ++i;
  }
}

• For all uints, use > 0 instead != 0
  • Seen throughout the contracts
• Use > value - 1 instead of >= value. Conversely, use < value + 1 instead of <= value
  • Seen throughout the contracts
• Drop into assembly for == 0 checks
  • Seen throughout the contracts e.g.

function isZero(uint256/address/bool/etc value) returns (bool result) {
  assembly {
    bool := iszero(value);
  } 
}

• Separate conditions
  • Seen throughout the contracts Instead of, e.g.

if (condition && anotherCondition) {
  doSomething();
}

Do

if (condition) {
  if (anotherCondition) {
    doSomething();
  }
}