Juicebox V2 contest - Funen's results

1. Using Bitwise OR assignment in fn _packedPermissions()

poc : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR_assignment

https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/JBOperatorStore.sol#L171

      packed |= 1 << _index;

in javasricpt that was gonna be :

x |= y // x = x | y

i dont know this can be the same as dev desire to be, since if we use this solidity operator :

https://www.geeksforgeeks.org/solidity-operators/ https://www.tutorialspoint.com/solidity/solidity_operators.htm https://medium.com/coinmonks/solidity-fundamentals-1fb0e6b3b607

it can be changed into :

      packed = packed | 1 << _index;

or

 packed | 1 << _index;

never found Bitwise OR assignment but dev can be looked into packed that would be the same as they wanted to be.

2. Lack of indexed

Since all interface was in scope this can be consider since it was missing indexed

1.) address beneficiary, address token

https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/interfaces/IJBSplitsPayer.sol#L17-L18

2.) address beneficiary, address token

https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/interfaces/IJBSplitsPayer.sol#L31-L32

3. Typo Comment

mumber => number

https://github.com/jbx-protocol/juice-contracts-v2-code4rena/blob/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/JBSingleTokenPaymentTerminalStore.sol#L384

    // The weight is always a fixed point mumber with 18 decimals. To ensure this, the ratio should use the same number of decimals as the `_amount`

1. Redundant Code hasPermission() and setOperator() in JBOperatorStore.sol

function hasPermission() line.57 and line.79

and

function setOperator() line.109 and line.134

how ever it can be simply to be used one function at the time, it would be saving more gas instead.

2. Using || than && operator can reduce gas cost

since this implementation below can be set since e.g on contracts/JBDirectory.sol (https://github.com/jbx-protocol/juice-contracts-v2-code4rena/tree/828bf2f3e719873daa08081cfa0d0a6deaa5ace5/contracts/JBDirectory.sol)

Line.133-136 Line.229-233 Line.266-268 Line.363-366

it can be reduce gas cost >200gas (a lot). but some it depend on that code but this can be consider if you wanted to saving more gas.

3. changed using ++i than i++ for cost less gas

Using i++ instead ++i for all the loops, the variable i is incremented using i++. It is known that implementation by using ++i costs less gas per iteration than i++.

/contracts/JBOperatorStore.sol#L85    for (uint256 _i = 0; _i < _permissionIndexes.length; _i++) 
/contracts/JBOperatorStore.sol#L135     for (uint256 _i = 0; _i < _operatorData.length; _i++) 
/contracts/JBOperatorStore.sol#L165    for (uint256 _i = 0; _i < _indexes.length; _i++) 
/contracts/JBDirectory.sol#L139    for (uint256 _i; _i < _terminalsOf[_projectId].length; _i++) 
/contracts/JBDirectory.sol#L167     for (uint256 _i; _i < _terminalsOf[_projectId].length; _i++)
/contracts/JBDirectory.sol#L275       for (uint256 _i; _i < _terminals.length; _i++)
/contracts/JBDirectory.sol#L276         for (uint256 _j = _i + 1; _j < _terminals.length; _j++)

4. change uint256 i = 0 into uint i for saving more gas

using this implementation can saving more gas for each loops.

/contracts/JBOperatorStore.sol#L85    for (uint256 _i = 0; _i < _permissionIndexes.length; _i++) 
/contracts/JBOperatorStore.sol#L135     for (uint256 _i = 0; _i < _operatorData.length; _i++) 
/contracts/JBOperatorStore.sol#L165    for (uint256 _i = 0; _i < _indexes.length; _i++)