Platform: Code4rena
Start Date: 17/03/2022
Pot Size: $30,000 USDC
Total HM: 8
Participants: 43
Period: 3 days
Judge: gzeon
Total Solo HM: 5
Id: 100
League: ETH
Rank: 34/43
Findings: 1
Award: $51.88
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: defsec
Also found by: 0x1f8b, 0xDjango, 0xNazgul, 0xkatana, 0xwags, CertoraInc, Funen, GeekyLumberjack, GreyArt, IllIllI, Kenshin, Ruhum, TerrierLover, WatchPug, berndartmueller, bugwriter001, cccz, cmichel, csanuragjain, hake, kenta, kirk-baird, leastwood, minhquanym, oyc_109, peritoflores, rayn, remora, rfa, robee, saian, samruna, sorrynotsorry, wuwe1
51.8842 USDC - $51.88
The function initialize()#PrePOMarketFactory.sol
function initialize() public initializer { OwnableUpgradeable.__Ownable_init(); @audit LOW reentracy guad uninitialized .... status entered }
Is missing to initialize ReentracyGuardUpgradeable.
This is not causing any harm because of the design of this contract. As this function internally only calls STATUS=!NOT_ENTERED with no impact on the logic. However, suppose OZ someday decide to upgrade this contract an you use the new version it is possible that your contract will not work.
Add __ReentrancyGuard_init_unchained(); as you did in colateral.sol
#0 - ramenforbreakfast
2022-03-24T04:05:42Z
duplicate of #13, but I consider this a higher quality submission since it correctly recognizes that this would not prevent the guard from working as intended.
Should use this as the source submission for mentions of this issue.