prePO contest - remora's results

1. Unused parameters

In #DepositHook.sol hook() function takes 3 parameters ( _sender, _initialAmount, _finalAmount). Here _initialAmount is unused

2. Redundant casting

In #PrePOMarketFactory.sol createMarket() type casting of ILongShortToken(address(_longToken) looks redundant.

 function createMarket(
        // 
       ....

    ) external override onlyOwner nonReentrant {
        require(_validCollateral[_collateral], "Invalid collateral");

        (
            LongShortToken _longToken,
            LongShortToken _shortToken
        ) = _createPairTokens(_tokenNameSuffix, _tokenSymbolSuffix);
        bytes32 _salt = keccak256(abi.encodePacked(_longToken, _shortToken));

        PrePOMarket _newMarket = new PrePOMarket{salt: _salt}(
            _governance,
            _collateral,
            ILongShortToken(address(_longToken)), //@audit redundant type casting 
            ILongShortToken(address(_shortToken)),
            _floorLongPrice,
            _ceilingLongPrice,
            _floorValuation,
            _ceilingValuation,
            _mintingFee,
            _redemptionFee,
            _expiryTime,
            false 
        );
....................
    }