Kuiper contest - pmerkleplant's results

Handle

pmerkleplant

Vulnerability details

Impact

When dealing with unsigned integer types, comparisons with != 0 are cheaper then with > 0.

Therefore, the following comparisons could be refactored:

Factory.sol:53: require(newBondPercentDiv > 0);
Basket.sol:68: require(_tokens.length > 0);
Basket.sol:77: require(_weights[i] > 0);
Basket.sol:93: require(amount > 0);
Basket.sol:110: require(amount > 0);
Basket.sol:291: require(tokenAmount > 0);

Tools used

grep

Handle

pmerkleplant

Vulnerability details

Impact

Caching the array length outside of a loop in a variable saves reading it on each iteration, as long as the array's length is not changed during the loop.

Therefore, the following loops could be refactored:

Basket.sol:79: for (uint256 x = 0; x < tokenList.length; x++)
Basket.sol:275: for (uint256 i = 0; i < weights.length; i++)
Basket.sol:282: for (uint256 i = 0; i < weights.length; i++)
Basket.sol:289: for (uint256 i = 0; i < weights.length; i++)
Auction.sol:88: for (uint256 i = 0; i < inputTokens.length; i++)
Auction.sol:92: for (uint256 i = 0; i < outputTokens.length; i++)
Auction.sol:105: for (uint256 i = 0; i < pendingWeights.length; i++)
Auction.sol:152: for (uint256 i = 0; i < bountyIds.length; i++)
Factory.sol:109: for (uint256 i = 0; i < bProposal.weights.length; i++)

Recommended Mitigation Steps

Use the following pattern for refactoring:

uint length = arr.length;
for (uint i = 0; i < length; i++) {
    // ...
}

Tools used

grep