Platform: Code4rena
Start Date: 08/12/2021
Pot Size: $30,000 ETH
Total HM: 12
Participants: 26
Period: 3 days
Judge: leastwood
Total Solo HM: 9
Id: 65
League: ETH
Rank: 15/26
Findings: 1
Award: $44.98
🌟 Selected for report: 1
🚀 Solo Findings: 0
🌟 Selected for report: rishabh
40.9479 USDC - $40.95
rishabh
In pushUnderlying function, there are no checks for tokenAmount being greater than zero. This will lead to the execution of safeTransfer function even when tokenAmount is zero and will cost extra gas for nothing.
Manual Code Review
#0 - frank-beard
2022-02-22T19:46:54Z
would consider this a gas optimization rather than an issue
#1 - 0xleastwood
2022-03-27T02:34:46Z
Agree this is a gas optimisation.
🌟 Selected for report: 0x0x0x
Also found by: Jujic, Meta0xNull, WatchPug, pmerkleplant, rishabh
rishabh
In validateWeights function, the length of tokenList will always be equal to _token length, so replacing tokenList.length at L79 with length declared at L70 will save gas
Manual Code Review
#0 - 0xleastwood
2022-03-27T10:31:53Z
Duplicate of #140