Olympus DAO contest - rokinot's results

Version 3 of Olympus protocol, a decentralized floating currency.

General Information

Platform: Code4rena

Start Date: 25/08/2022

Pot Size: $75,000 USDC

Total HM: 35

Participants: 147

Period: 7 days

Judge: 0xean

Total Solo HM: 15

Id: 156

League: ETH

Olympus DAO

Findings Distribution

Researcher Performance

Rank: 84/147

Findings: 2

Award: $86.89

🌟 Selected for report: 0

🚀 Solo Findings: 0

Non-critical

Misleading comment, should be // a-z and _ only

https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol#L61

Low

Protocol executor can exercise any of the admin functions, since he has the ability to switch roles including the admin role itself. The comment prior should specify this case scenario.

https://github.com/code-423n4/2022-08-olympus/blob/main/src/Kernel.sol#L439

Someone can be given the roles "Admin" or "Executor" or variations with different letter casings, without any of the admin or executor functions. The exercising of the protocol is not affected though this ambiguity can be avoided.

https://github.com/code-423n4/2022-08-olympus/blob/main/src/Kernel.sol#L439

Instruction ID 0 is skipped

In order to not skip id 0, use totalInstructions++ instead of ++totalInstructions

https://github.com/code-423n4/2022-08-olympus/blob/main/src/modules/INSTR.sol#L44

Unreachable portions of the code should be deleted

https://github.com/code-423n4/2022-08-olympus/blob/main/src/modules/VOTES.sol#L47

Notice that removing this line of code can also save deployment gas.

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter