Debt DAO contest - sakman's results

A cryptonative credit marketplace for fully anon and trustless loans to DAOs.

General Information

Platform: Code4rena

Start Date: 03/11/2022

Pot Size: $115,500 USDC

Total HM: 17

Participants: 120

Period: 7 days

Judge: LSDan

Total Solo HM: 1

Id: 174

League: ETH

Debt DAO

Findings Distribution

Researcher Performance

Rank: 89/120

Findings: 1

Award: $61.35

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

1. Do not leave the receive/fallback function empty

contracts/modules/credit/SpigotedLine.sol: L272 L273

2. Use external instead of public for the following functions

contracts/utils/CreditLib.sol: L236

3. Only libraries, abstract contracts and interfaces should use multiple compiler versions

contracts/modules/credit/SpigotedLine.sol: L1

contracts/modules/oracle/Oracle.sol: L2

contracts/modules/credit/SecuredLine.sol: L1

contracts/modules/credit/LineOfCredit.sol: L1

contracts/modules/interest-rate/InterestRateCredit.sol: L1

4. Use e18 notation instead of **18

contracts/utils/CreditLib.sol: L117

contracts/utils/EscrowLib.sol: L42

5. Returning named return variables is redundant

contracts/utils/SpigotLib.sol: L29-L57 L83-L101 L105-L121

contracts/utils/CreditLib.sol: L125-L160

contracts/modules/credit/LineOfCredit.sol: L435-L453

#0 - c4-judge

2022-12-06T20:55:44Z

dmvt marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter