Platform: Code4rena
Start Date: 27/01/2022
Pot Size: $75,000 USDC
Total HM: 10
Participants: 26
Period: 7 days
Judge: pauliax
Total Solo HM: 5
Id: 81
League: ETH
Rank: 13/26
Findings: 2
Award: $549.03
π Selected for report: 1
π Solo Findings: 0
538.5314 USDC - $538.53
samruna
https://github.com/code-423n4/2022-01-notional/blob/main/contracts/sNOTE.sol#L133
No upper limit check on swapFeePercentage. Although only owner can set this, human error can lead to higher percente swap, leading to excess swap and gas fee.
#0 - jeffywu
2022-02-06T14:32:05Z
Severity should be Low Risk
#1 - pauliax
2022-02-14T19:41:10Z
Having a reasonable upper boundary would be a good improvement here, but I agree with the sponsor that this should be of low severity.
π Selected for report: pauliax
Also found by: Jujic, ShippooorDAO, SolidityScan, WatchPug, gzeon, samruna, throttle
10.4991 USDC - $10.50
samruna
https://github.com/code-423n4/2022-01-notional/blob/main/contracts/TreasuryManager.sol#L35
Remove unused refundGasPrice variable.
#0 - jeffywu
2022-02-06T14:31:44Z
Severity should be Gas Optimization
#1 - pauliax
2022-02-14T14:19:00Z
Agree, it is a gas optimization.
#2 - pauliax
2022-02-15T08:35:26Z
#204