Platform: Code4rena
Start Date: 27/01/2022
Pot Size: $75,000 USDC
Total HM: 10
Participants: 26
Period: 7 days
Judge: pauliax
Total Solo HM: 5
Id: 81
League: ETH
Rank: 20/26
Findings: 1
Award: $80.95
🌟 Selected for report: 0
🚀 Solo Findings: 0
23.0433 USDC - $23.04
throttle
Gas savings
Using pre-increment (++i) instead of post-increment (i++) saves a few units of gas every spin of the loop: https://github.com/code-423n4/2022-01-notional/blob/main/contracts/TreasuryAction.sol#L157
Manual review
Change i++ to ++i
#0 - jeffywu
2022-02-06T15:00:26Z
Duplicate #228
#1 - pauliax
2022-02-13T10:35:44Z
#228
🌟 Selected for report: pauliax
Also found by: Jujic, ShippooorDAO, SolidityScan, WatchPug, gzeon, samruna, throttle
10.4991 USDC - $10.50
gzeon
The refundGasPrice variable in TreasuryManager is unused.
uint32 public refundGasPrice;
$ grep -Rn "refundGasPrice" ./contracts/ ./contracts/TreasuryManager.sol:35: uint32 public refundGasPrice;
#0 - jeffywu
2022-02-06T15:25:42Z
Duplicate #38
#1 - pauliax
2022-02-14T14:26:32Z
#184
#2 - pauliax
2022-02-15T08:38:34Z
#204
🌟 Selected for report: TomFrenchBlockchain
47.4141 USDC - $47.41
throttle
Gas savings
Assigning default values costs unnecessary gas. https://github.com/code-423n4/2022-01-notional/blob/main/contracts/sNOTE.sol#L112-L113
Manual review
Removing assignments.
#0 - jeffywu
2022-02-06T14:39:48Z
This is true. Solidity does guarantee memory slots are zero right now, but this may change in the future.
#1 - pauliax
2022-02-15T08:44:05Z
#59