Paladin - Warden Pledges contest - 0x007's results

A governance lending protocol transforming users voting power into a new money lego.

General Information

Platform: Code4rena

Start Date: 27/10/2022

Pot Size: $33,500 USDC

Total HM: 8

Participants: 96

Period: 3 days

Judge: kirk-baird

Total Solo HM: 1

Id: 176

League: ETH

Paladin

Findings Distribution

Researcher Performance

Rank: 71/96

Findings: 1

Award: $19.64

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

  1. variable protocalFeeRatio should be protocolFeeRatio. There are 6 cases that needs correction in WardenPledge
  2. oldfee ought to be in camelCase oldFee in line 117 and line 627. This is to maintain consistency and it's quite important in L117 cause event name are used in data analytics.
  3. ClosePledge event is not emitted in retrievePledgeRewards function when the pledge was closed in line 469. The purpose is also for analytics and should be updated.
if(!pledgeParams.closed) {
    pledgeParams.closed = true;
    emit ClosePledge(pledgeId);
}
  1. Reward tokens with less than 18 decimals will not work well because of constant UNIT in line 22 e.g using USDC instead of DAI.
  2. There are lots of typo errors in the documentation.

#0 - c4-judge

2022-11-12T00:18:28Z

kirk-baird marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter