Platform: Code4rena
Start Date: 27/10/2022
Pot Size: $33,500 USDC
Total HM: 8
Participants: 96
Period: 3 days
Judge: kirk-baird
Total Solo HM: 1
Id: 176
League: ETH
Rank: 71/96
Findings: 1
Award: $19.64
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: robee
Also found by: 0x007, 0x1f8b, 0x52, 0xDjango, 0xNazgul, 0xSmartContract, 8olidity, Awesome, B2, Bnke0x0, Chom, Diana, Dravee, JTJabba, Jeiwan, Josiah, Lambda, Mathieu, Picodes, RaoulSchaffranek, RaymondFam, RedOneN, ReyAdmirado, Rolezn, Ruhum, Sm4rty, Tricko, Trust, Waze, __141345__, a12jmx, adriro, ajtra, brgltd, c3phas, carlitox477, cccz, ch0bu, chaduke, chrisdior4, corerouter, cryptonue, csanuragjain, ctf_sec, cylzxje, delfin454000, dic0de, djxploit, horsefacts, imare, jayphbee, jwood, ktg, ladboy233, leosathya, lukris02, minhtrng, neko_nyaa, oyc_109, pashov, peritoflores, rbserver, rvierdiiev, shark, tnevler, yixxas
19.6449 USDC - $19.64
protocalFeeRatio
should be protocolFeeRatio
. There are 6 cases that needs correction in WardenPledgeoldfee
ought to be in camelCase oldFee
in line 117 and line 627. This is to maintain consistency and it's quite important in L117 cause event name are used in data analytics.ClosePledge
event is not emitted in retrievePledgeRewards
function when the pledge was closed in line 469. The purpose is also for analytics and should be updated.if(!pledgeParams.closed) { pledgeParams.closed = true; emit ClosePledge(pledgeId); }
UNIT
in line 22 e.g using USDC instead of DAI.#0 - c4-judge
2022-11-12T00:18:28Z
kirk-baird marked the issue as grade-b