Platform: Code4rena
Start Date: 27/10/2022
Pot Size: $33,500 USDC
Total HM: 8
Participants: 96
Period: 3 days
Judge: kirk-baird
Total Solo HM: 1
Id: 176
League: ETH
Rank: 69/96
Findings: 1
Award: $19.64
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: robee
Also found by: 0x007, 0x1f8b, 0x52, 0xDjango, 0xNazgul, 0xSmartContract, 8olidity, Awesome, B2, Bnke0x0, Chom, Diana, Dravee, JTJabba, Jeiwan, Josiah, Lambda, Mathieu, Picodes, RaoulSchaffranek, RaymondFam, RedOneN, ReyAdmirado, Rolezn, Ruhum, Sm4rty, Tricko, Trust, Waze, __141345__, a12jmx, adriro, ajtra, brgltd, c3phas, carlitox477, cccz, ch0bu, chaduke, chrisdior4, corerouter, cryptonue, csanuragjain, ctf_sec, cylzxje, delfin454000, dic0de, djxploit, horsefacts, imare, jayphbee, jwood, ktg, ladboy233, leosathya, lukris02, minhtrng, neko_nyaa, oyc_109, pashov, peritoflores, rbserver, rvierdiiev, shark, tnevler, yixxas
19.6449 USDC - $19.64
In line 468 of WardenPledge.sol, the Pledge is set as closed if it is not closed which has same effect with closePledge() function. However, the ClosePledge() event is not emitted in this case while ClosePledge() event is emitted in closePledge() function.
Change the related codes from:
if(!pledgeParams.closed) pledgeParams.closed = true;
to:
if(!pledgeParams.closed) { pledgeParams.closed = true; emit ClosePledge(pledgeId); }
#0 - trust1995
2022-10-30T21:53:45Z
Don't believe a missing event qualifies for medium severity. It is a valuable QA suggestion.
#1 - Kogaroshi
2022-10-30T23:45:14Z
Duplicate of #111
#2 - kirk-baird
2022-11-11T21:45:47Z
This is amount a missing event rather than incorrect documentation (as in #111) so I'm going to consider this QA.
#3 - c4-judge
2022-11-11T21:45:58Z
kirk-baird changed the severity to QA (Quality Assurance)
#4 - c4-judge
2022-11-12T00:20:54Z
kirk-baird marked the issue as grade-b