Paladin - Warden Pledges contest - lukris02's results

QA Report for Paladin - Warden Pledges contest

Overview

During the audit, 1 low and 5 non-critical issues were found.

Low Risk Findings (1)

L-1. Missing check for zero address

Description

If address(0x0) is set it may cause the contract to revert or work wrong.

Instances

• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L137
• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L138
• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L140

Recommendation

Add checks.

Non-Critical Risk Findings (5)

NC-1. Misleading function name

Instances

• L148-L155:

    /**
    * @notice Amount of Pledges listed in this contract
    * @dev Amount of Pledges listed in this contract
    * @return uint256: Amount of Pledges listed in this contract
    */
    function pledgesIndex() public view returns(uint256){
        return pledges.length;
    }

Recommendation

Consider changing the name to pledgesLength() or pledgesAmount().

NC-2. Order of Functions

Description

According to Style Guide, ordering helps readers identify which functions they can call and to find the constructor and fallback definitions easier.
Functions should be grouped according to their visibility and ordered:

1. constructor
2. receive function (if exists)
3. fallback function (if exists)
4. external
5. public
6. internal
7. private

Instances

Internal function should be after external:

• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L525

Public function should be after external:

• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L153

Recommendation

Reorder functions where possible.

NC-3. Spaces between the control structures

Description

According to Style Guide, there should be a single space between the control structures if, while, and for and the parenthetic block representing the conditional.

Instances

• 64 instances with if(
• 1 instance with for(

Recommendation

Change:

if(...) 

to:

if (...) 

NC-4. Maximum line length exceeded

Description

Some lines of code are too long.

Instances

• (135 symbols) https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L234
• (135) https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L245
• (134) https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L383

Recommendation

According to Style Guide, maximum suggested line length is 120 characters.
Make the lines shorter.

NC-5. Typos

Instances

• * @param targetVotes Maximum taget of votes to have (own balacne + delegation) for the receiver => target
• * @param targetVotes Maximum taget of votes to have (own balacne + delegation) for the receiver => balance
• * @param maxTotalRewardAmount Maximum total reward amount allowed ot be pulled by this contract => to
• * @param maxFeeAmount Maximum feeamount allowed ot be pulled by this contract => fee amount
• * @param maxFeeAmount Maximum feeamount allowed ot be pulled by this contract => to
• // Add the total reards as available for the Pledge & write Pledge parameters in storage => rewards
• * @param maxTotalRewardAmount Maximum added total reward amount allowed ot be pulled by this contract => to
• * @param maxFeeAmount Maximum fee amount allowed ot be pulled by this contract => to
• * @param pledgeId ID fo the Pledge => for
• * @param pledgeId ID fo the Pledge to close => for
• * @param minRewardPerSecond Minmum amount of reward per vote per second for the token => Minimum
• * @param minRewardsPerSecond Minmum amount of reward per vote per second for each token in the list => Minimum
• * @param minRewardPerSecond Minmum amount of reward per vote per second for the token => Minimum
• * @param minRewardPerSecond Minmum amount of reward per vote per second for the token => Minimum

Gas Optimizations Report for Paladin - Warden Pledges contest

Overview

During the audit, 3 gas issues were found.
Total savings ~200.

Gas Optimizations Findings (3)

G-1. Use unchecked blocks for subtractions where underflow is impossible

Description

In Solidity 0.8+, there’s a default overflow and underflow check on unsigned integers. When an overflow or underflow isn’t possible (after require or if-statement), some gas can be saved by using unchecked blocks.

Instances

• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L268
• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L385
• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L430
• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L431

Saved

This saves ~35.
So, ~35*4 = 140

G-2. Use local variable cache instead of accessing mapping or array multiple times

Description

It saves gas due to not having to perform the same key’s keccak256 hash and/or offset recalculation.

Instances

• (minAmountRewardToken[rewardToken], 2nd access) https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L313

Saved

This saves ~40.
So, ~40*1 = 40

G-3. Unnecessary write to the memory variable

Description

When array or mapping accessed only once, there is no need to use local variable.

Instances

• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L458
• https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L490

Saved

This saves ~3.
So, ~3*2 = 6