Forgotten Runes Warrior Guild contest - 0x4non's results

Consider to add event emission to critical onlyOwner functions;

https://github.com/code-423n4/2022-05-runes/blob/main/contracts/ForgottenRunesWarriorsGuild.sol#L125-L176 https://github.com/code-423n4/2022-05-runes/blob/main/contracts/ForgottenRunesWarriorsMinter.sol#L424-L630

Also end user critical functions should emit events (refunds, bidSummon, mintlistSummon, publicSummon, claimSummon, teamSummon)

Gas optimizations

Use immutable in variables that shouldnt change

I recommend to set contract variables WETH, warriors and vault as immutable, these variables shouldnt change, then you could remove functions, setWarriorsAddress, setWethAddress, setVaultAddress. Now the constructor should be

    constructor(IForgottenRunesWarriorsGuild _warriors, address _weth) {
        warriors = _warriors;
        weth = _weth;
        vault = msg.sender;
    }

Use internal copy of array instead of using daMinters

Consider reeplacing theses lines https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L355-L357 For

        address[] memory _daMinters = daMinters;
        for (uint256 i = startIdx; i < endIdx + 1;) {
            _refundAddress(_daMinters[i]);
            unchecked {
                i++;
            }
        }

Use unchecked in safe operarions

Since numWarriors input is validated and lower equal than 20 you could use unchecked in this lines https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L152-L154

        unchecked {
            daAmountPaid[msg.sender] += msg.value;
            daNumMinted[msg.sender] += numWarriors;
            numSold += numWarriors;
        }

Use unchecked in https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L193

        unchecked{ numSold += 1; }

Use unchecked in (numWarriors is equal or less than 20 so there is no overflow issue) https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L219

        unchecked { numSold += numWarriors; }

Use unchecked in https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L248

        unchecked { numClaimed += 1; }

Use unchecked in https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L379

        unchecked { daAmountRefunded[minter] += owed; }

Use unchecked in for loops

Consider to change loops pattern from;

    for (uint256 i = 0; i < length; i++) {
        // CODE
    }

To

    for (uint256 i = 0; i < length;) {
        // CODE
        unchecked { i++; }
    }

For loops:

Change this lines https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L162-L164 For

        for (uint256 i = 0; i < numWarriors;) {
            _mint(msg.sender);
            unchecked { i++; }
        }

Change this lines https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L220-L222 For

        for (uint256 i = 0; i < numWarriors;) {
            _mint(msg.sender);
            unchecked { i++; }
        }

Change this lines https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L259-L261 For

        for (uint256 i = 0; i < count;) {
            _mint(recipient);
            unchecked { i++; }
        }

This lines https://github.com/code-423n4/2022-05-runes/blob/f562bc57045af5897785e2542878b01ead127775/contracts/ForgottenRunesWarriorsMinter.sol#L354-L358 For

    {
        address[] memory _daMinters = daMinters;
        for (uint256 i = startIdx; i < endIdx + 1;) {
            _refundAddress(_daMinters[i]);
            unchecked {
                i++;
            }
        }
    }
    ```