Forgotten Runes Warrior Guild contest - 0xc0ffEE's results

1. Should implement a function that used for minting an amount of tokens. This could save gas by reducing the times that ForgottenRunesWarriorMinter makes external call to ForgottenRunesWarriorGuild during DA phase and Public phase The function could likely be:

function mint(address recipient,uint256 amount) external nonReentrant {
  require(numMinted + amount <= MAX_WARRIORS);
  require(_msgSender() == minter);
  for(unt256 i = 0; i < amount ; ++i){
    _safeMint(recipient, numMinted + i);
  }
  numMinted += amount;
}

ForgottenRunesWarriorMinter.sol#[L162:L164] and ForgottenRunesWarriorMinter.sol#[L220:L222] could be replaced by warriors.mint(msg.sender, numWarriors)

2. ForgottenRunesWarriorGuild.sol#L24 No need assignment of numMinted = 0

3. Recommendation: Manage ForgottenRunesWarriorMinter.sol#L73 as a set data structure to save gas for both bidSummon and issueRefund execution, i.e using EnumerableSet library from OpenZeppelin, such that: using Enumberable.AddressSet daMinters instead of address[] daMinters By using OpenZeppelin EnumerableSet, ForgottenRunesWarriorMinter.sol#L151 could be replaced by daMinters.add(msg.sender). This could costs more gas for the first time that user execute bidSummon(uint256) than using push(msg.sender) but the next times that user executes bidSummon(uin256), the gas cost is lower because the address is already in the set. Similarly, issueRefunds(uint256,uint256) will cost lower by just process an address just once because this decreases the number of operations with storage. Moreover, consider removing the address processed from set to release storage and get negative gas cost if there is no need for retrieving daMinters.

4. Underflow condition not met at ForgottenRunesWarriorMinter.sol#L288 and ForgottenRunesWarriorMinter.sol#L296, so consider using unchecked for gas saving