Platform: Code4rena
Start Date: 03/05/2022
Pot Size: $30,000 USDC
Total HM: 6
Participants: 93
Period: 3 days
Judge: gzeon
Id: 118
League: ETH
Rank: 31/93
Findings: 2
Award: $261.99
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: Kulk0
Also found by: 0x1f8b, 0xDjango, BowTiedWardens, Dinddle, broccolirob, defsec, dirk_y, hyh, rajatbeladiya, throttle, unforgiven
Team Summon has no limit (Non-critical/low)
The teamSummon function has no limit to how many can be minted and can also do this at any time. This could lead to minting over the supply of 16,000 as stated by the distribution section on https://www.forgottenrunes.com/ja/warriors.
Recommendation:
Require that count and the total minted supply do not exceed 16,000.
Affected lines of code:
#0 - gzeoneth
2022-06-19T15:59:27Z
Duplicate of #104
🌟 Selected for report: BowTiedWardens
Also found by: 0v3rf10w, 0x1f8b, 0x4non, 0xDjango, 0xNazgul, 0xProf, 0xc0ffEE, 0xf15ers, 0xkatana, 0xliumin, ACai, AlleyCat, CertoraInc, Cityscape, Cr4ckM3, DavidGialdi, Dinddle, FSchmoede, Funen, GimelSec, Hawkeye, IllIllI, Kulk0, M0ndoHEHE, MaratCerby, MiloTruck, Picodes, RoiEvenHaim, Tadashi, TerrierLover, TrungOre, VAD37, WatchPug, antonttc, catchup, defsec, delfin454000, dirk_y, eccentricexit, ellahi, fatherOfBlocks, gzeon, hake, hansfriese, hickuphh3, horsefacts, ilan, joestakey, kebabsec, kenta, kenzo, marximimus, minhquanym, noobie, oyc_109, p4st13r4, pauliax, rajatbeladiya, reassor, rfa, robee, rotcivegaf, saian, samruna, shenwilly, shung, simon135, slywaters, sorrynotsorry, throttle, unforgiven, z3s
15.4498 USDC - $15.45
Unchecked in for loop to save on a little gas:
In solidity 0.8.0 and above, it now checks underflows/overflows automatically. Because we know that the for loop is bounded and will never have the chance to do so, we can skip that check and save a little gas.
Example:
for (uint256 i = 0; i < 10; ) { // do something unchecked{ i++; } }
Affected lines of code: