Platform: Code4rena
Start Date: 10/03/2022
Pot Size: $75,000 USDT
Total HM: 25
Participants: 54
Period: 7 days
Judge: pauliax
Total Solo HM: 10
Id: 97
League: ETH
Rank: 41/54
Findings: 2
Award: $179.09
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: hickuphh3
Also found by: 0v3rf10w, 0x1f8b, 0xDjango, 0xNazgul, 0xngndev, 0xwags, Cantor_Dust, CertoraInc, Dravee, IllIllI, PPrieditis, Ruhum, TerrierLover, WatchPug, XDms, benk10, berndartmueller, bitbopper, catchup, cmichel, cryptphi, csanuragjain, danb, defsec, gzeon, hagrid, hubble, jayjonah8, kenta, kyliek, minhquanym, rfa, robee, saian, samruna, throttle, ye0lde, z3s
119.6037 USDT - $119.60
Missing parameter for string:
Consider adding a comment that explains the purpose of the string.
Ensure that rewardPerSecond is not default value, :
require(_rewardPerSecond! =0, “ “) ;
Use addition assignment for better readability :
Incorrect import
The import below is not amongst the hyphen contracts :
consider importing directly from the OZ contracts.
Unused return variable:
#0 - CloudEllie
2022-03-19T21:56:18Z
Warden 0xwags submitted a request March 17 that the following section be withdrawn from this QA report:
The import below is not amongst the hyphen contracts :
consider importing directly from the OZ contracts.
They commented: "The sponsor confirmed that it was an npm import hours after I submitted."
Deferring to the judge as to whether this context should have been clear from the available documentation.
#1 - pauliax
2022-05-09T13:13:06Z
Warden 0xwags submitted a request March 17 that the following section be withdrawn from this QA report:
The import below is not amongst the hyphen contracts : https://github.com/code-423n4/2022-03-biconomy/blob/04751283f85c9fc94fb644ff2b489ec339cd9ffc/contracts/hyphen/token/LPToken.sol#L10 consider importing directly from the OZ contracts.
They commented: "The sponsor confirmed that it was an npm import hours after I submitted."
Deferring to the judge as to whether this context should have been clear from the available documentation.
I will still consider this as a non-critical issue when evaluating the score.
🌟 Selected for report: Dravee
Also found by: 0v3rf10w, 0x1f8b, 0xDjango, 0xNazgul, 0xngndev, 0xwags, Cantor_Dust, CertoraInc, IllIllI, Jujic, Kenshin, Kiep, PPrieditis, TerrierLover, Tomio, WatchPug, antonttc, benk10, berndartmueller, bitbopper, csanuragjain, defsec, gzeon, hagrid, hickuphh3, kenta, minhquanym, oyc_109, pedroais, peritoflores, rfa, robee, saian, samruna, sirhashalot, throttle, wuwe1, z3s
59.4896 USDT - $59.49
Use unchecked block:
Since the line prior to the aforementioned checks that currentLiquidity is the smaller operand of the two , you can use the unchecked block as it will not lead to an underflow.
Unnecessary initialisation of default values.
The lowest value represented by uint256 is 0,so no need to assign it: