Platform: Code4rena
Start Date: 10/03/2022
Pot Size: $75,000 USDT
Total HM: 25
Participants: 54
Period: 7 days
Judge: pauliax
Total Solo HM: 10
Id: 97
League: ETH
Rank: 51/54
Findings: 1
Award: $59.80
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: Dravee
Also found by: 0v3rf10w, 0x1f8b, 0xDjango, 0xNazgul, 0xngndev, 0xwags, Cantor_Dust, CertoraInc, IllIllI, Jujic, Kenshin, Kiep, PPrieditis, TerrierLover, Tomio, WatchPug, antonttc, benk10, berndartmueller, bitbopper, csanuragjain, defsec, gzeon, hagrid, hickuphh3, kenta, minhquanym, oyc_109, pedroais, peritoflores, rfa, robee, saian, samruna, sirhashalot, throttle, wuwe1, z3s
59.8019 USDT - $59.80
All structs in HyphenLiquidityFarming can be packed into a single storage slot to save SLOAD and SSTORE, which saves enormous amount of gas:
example:
/// can pack bool with the 2 numbers too! struct NFTInfo { address payable staker; uint128 rewardDebt; uint128 unpaidRewards; bool isStaked; } /// uint256 -> uint128 struct PoolInfo { uint128 accTokenPerShare; uint128 lastRewardTime; } /// uint256 -> uint128 struct RewardsPerSecondEntry { uint128 rewardsPerSecond; uint128 timestamp; }
Because the tests suites wasn't passing originally, i couldn't done a very thorough test on how much gas it will actually save. But from those successful txs, it saves an average of 10~20K gas on all operations touching these variables.
···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · deposit · 302889 · 347856 · 324711 · 40 · - │ ···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · extractRewards · 115958 · 156837 · 135652 · 10 · - │ ···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · initalizeRewardPool · 125021 · 125033 · 125030 · 34 · - │ ···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · setRewardPerSecond · 64836 · 84760 · 80768 · 5 · - │ ···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · withdraw · 243151 · 308028 · 269281 · 26 · - │ ···························|······································|·············|·············|·············|···············|··············
···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · deposit · 291283 · 335177 · 314866 · 40 · - │ ···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · extractRewards · 109379 · 150258 · 128487 · 10 · - │ ···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · initalizeRewardPool · 103023 · 103035 · 103032 · 34 · - │ ···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · setRewardPerSecond · 62726 · 62750 · 62738 · 5 · - │ ···························|······································|·············|·············|·············|···············|·············· | HyphenLiquidityFarming · withdraw · 236572 · 301449 · 260729 · 26 · - │ ···························|······································|·············|·············|·············|···············|··············
Hope this helps!