Biconomy Hyphen 2.0 contest - csanuragjain's results

Next-Gen Multichain Relayer Protocol.

General Information

Platform: Code4rena

Start Date: 10/03/2022

Pot Size: $75,000 USDT

Total HM: 25

Participants: 54

Period: 7 days

Judge: pauliax

Total Solo HM: 10

Id: 97

League: ETH

Biconomy

Findings Distribution

Researcher Performance

Rank: 43/54

Findings: 2

Award: $178.68

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

119.1774 USDT - $119.18

Labels

bug
QA (Quality Assurance)

External Links

QA report of the warden: csanuragjain

Issues: https://github.com/code-423n4/2022-03-biconomy-findings/issues/22

Awards

59.5017 USDT - $59.50

Labels

bug
G (Gas Optimization)

External Links

ExecutorManager.sol

  1. getAllExecutors/addExecutor/removeExecutor function can be declared external instead of public

TokenManager.sol

  1. changeFee function: add modifier tokenChecks which will validate the passed token address
  2. setDepositConfig function: check if tokenAddresses is non zero and supported
  3. getEquilibriumFee/getMaxFee/getTransferConfig function can be declared external instead of public

LiquidityPool.sol

  1. tokenManager variable can be immutable
  2. setBaseGas function: add a check to see new gas is greater than base gas which was initially set in constructor ie gas>21000

#0 - pauliax

2022-05-09T08:12:24Z

ExecutorManager 1 is not valid because these functions are also called internally, and making a function external does not always save gas. TokenManager 3 the same. LiquidityPool 1 can't be set to immutable because the variable is initialized in a function, not a constructor.

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter