Putty contest - AmitN's results

An order-book based american options market for NFTs and ERC20s.

General Information

Platform: Code4rena

Start Date: 29/06/2022

Pot Size: $50,000 USDC

Total HM: 20

Participants: 133

Period: 5 days

Judge: hickuphh3

Total Solo HM: 1

Id: 142

League: ETH

Putty

Findings Distribution

Researcher Performance

Rank: 85/133

Findings: 2

Award: $52.71

🌟 Selected for report: 0

πŸš€ Solo Findings: 0

Awards

5.5216 USDC - $5.52

Labels

bug
duplicate
2 (Med Risk)

External Links

Lines of code

https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L443

Vulnerability details

some functions are payable but ether should be sent only in certain conditions. for example, when calling exercise for a put option ether should not be sent but it's still possible.

check that msg.value is zero when it should be.

#0 - rotcivegaf

2022-07-04T23:38:01Z

A part duplicate of #226

#1 - outdoteth

2022-07-06T19:27:03Z

Duplicate: Native ETH can be lost if it’s not utilised in exercise and fillOrder: https://github.com/code-423n4/2022-06-putty-findings/issues/226

Lines of code

https://github.com/code-423n4/2022-06-putty/blob/main/contracts/src/PuttyV2.sol#L526

Vulnerability details

All orders can be canceled, but orders that have already been filled shouldn't be canceled, because it won't have any effect.

Recommendation mitigation steps

check that the canceled order has not been filled.

#0 - outdoteth

2022-07-07T14:00:35Z

Duplicate: Order can be cancelled even if order was already filled: https://github.com/code-423n4/2022-06-putty-findings/issues/396

#1 - HickupHH3

2022-07-11T00:53:48Z

Warden did not submit QA report, this will be the primary.

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax Β© 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter