Putty contest - doddle0x's results

[N-01] PUBLIC FUNCTIONS NOT CALLED BY THE CONTRACT SHOULD BE DECLARED EXTERNAL INSTEAD

6 instances of the issue

File: PuttyV2.sol
389:     function exercise(Order memory order, uint256[] calldata floorAssetTokenIds) public payable {

File: PuttyV2.sol
466:     function withdraw(Order memory order) public {

File: PuttyV2.sol
546:     function batchFillOrder(
        Order[] memory orders,
        bytes[] calldata signatures,
        uint256[][] memory floorAssetTokenIds
    ) public returns (uint256[] memory positionIds) {

File: PuttyV2.sol
573:     function acceptCounterOffer(
        Order memory order,
        bytes calldata signature,
        Order memory originalOrder
    ) public payable returns (uint256 positionId) {

File: PuttyV2.sol
753:     function domainSeparatorV4() public view returns (bytes32) {

File: PuttyV2.sol
764:     function tokenURI(uint256 id) public view override returns (string memory) {

[N-02] CONSTANTS SHOULD BE DEFINED

5 instances of the issue

File: PuttyV2.sol
241:     require(_fee < 30, "fee must be less than 3%");

File: PuttyV2.sol
287:     require(order.duration < 10_000 days, "Duration too long");

File: PuttyV2.sol
413:     transferFrom(msg.sender, address(0xdead), uint256(orderHash));

File: PuttyV2.sol
488:     transferFrom(msg.sender, address(0xdead), uint256(orderHash));

File: PuttyV2.sol
499:     feeAmount = (order.strike * fee) / 1000;

[N-03] MISSING EVENT FOR ORDER CHANGE

I would consider beneficial to have an event when an order is countered and a new created, vs the standard flow cancel and create. This will make any traceability clear. Function acceptCounterOffer() doesn't emit any event.

File: PuttyV2.sol
573:     function acceptCounterOffer(
        Order memory order,
        bytes calldata signature,
        Order memory originalOrder
    ) public payable returns (uint256 positionId) {

[N-04] INCONSISTENT USER of bytes32 vs uint256

3 mappings track the state of the orders. cancelledOrders is using bytes32 while positionExpirations and exercisedPositions are using uint256 as key.