Platform: Code4rena
Start Date: 05/01/2023
Pot Size: $90,500 USDC
Total HM: 55
Participants: 103
Period: 14 days
Judge: Picodes
Total Solo HM: 18
Id: 202
League: ETH
Rank: 77/103
Findings: 1
Award: $51.32
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: ladboy233
Also found by: 0x1f8b, 0xAgro, 0xSmartContract, 0xbepresent, 0xkato, Aymen0909, CodingNameKiki, Cryptor, Deekshith99, Deivitto, HE1M, IllIllI, Kaysoft, Koolex, PaludoX0, Qeew, RaymondFam, Rolezn, Sathish9098, Tointer, a12jmx, arialblack14, ast3ros, ayeslick, bin2chen, btk, caventa, ch0bu, chaduke, chrisdior4, delfin454000, descharre, evan, fatherOfBlocks, georgits, gz627, jasonxiale, joestakey, kaden, lukris02, nicobevi, nogo, oberon, oyc_109, pfapostol, rbserver, sakshamguruji, seeu, shark, simon135, slvDev, synackrst, tnevler, whilom, zaskoh
51.3151 USDC - $51.32
There are 15 instances of it its recommend to remove unused imports from the contracts for better readability of the code here are the permalinks of them ClearingHouse.sol#L17, ClearingHouse.sol#L24-L26, CollateralToken.sol#L33, CollateralToken.sol#L59, PublicVault.sol#L24, PublicVault.sol#L27, AstariaRouter.sol#L42, LienToken.sol#L34, AstariaVaultBase.sol#L18, AstariaVaultBase.sol#L21, VaultImplementation.sol#L25, IPublicVault.sol#L16, ICollateralToken.sol#L27, IAstariaRouter.sol#L16, IAstariaRouter.sol#L25
it could be better if they add natspec comments in this contract here is the permalink of the contract ClearingHouse.sol
here is the permalink of it AstariaRouter.sol#L73
uint88 maxInterestRate; //6
it should be as
uint88 maxInterestRate; //11
because in the context for the uint88 converts as 11 bytes
so instead of 6 it should replace with 11
#0 - c4-judge
2023-01-26T14:07:16Z
Picodes marked the issue as grade-b