Infinity NFT Marketplace contest - FSchmoede's results

QA report

[L-01] Wrong check in require statement

In the require statement in InfinityStaker.sol at L193 the intention is to check whether the users total staked tokens is not 0. However the require statement looks like this:

require(totalStaked >= 0, 'nothing staked to rage quit');

This condition will always be true for a uint256 since it can never be below 0 anyways. Thus this require statement will never revert at this point.

It should instead be changed to

require(totalStaked > 0, 'nothing staked to rage quit');

[NC-01] Capitalized variable names for non-constants

Only variables defined as constant or immutables should be named in capital, see Solidity style guide for constants.

For non-constant variables the mixedCase naming should be used instead, see Solidity style guide for local and state variables.

File InfinityExchange.sol:

address public MATCH_EXECUTOR;
uint32 public WETH_TRANSFER_GAS_UNITS = 50000;
uint16 public PROTOCOL_FEE_BPS = 250;

File InfinityStaker.sol:

address public INFINITY_TOKEN;
address public INFINITY_TREASURY;
uint16 public BRONZE_STAKE_THRESHOLD = 1000;
uint16 public SILVER_STAKE_THRESHOLD = 5000;
uint16 public GOLD_STAKE_THRESHOLD = 10000;
uint16 public PLATINUM_STAKE_THRESHOLD = 20000;
uint16 public THREE_MONTH_PENALTY = 2;
uint16 public SIX_MONTH_PENALTY = 3;
uint16 public TWELVE_MONTH_PENALTY = 4;

Gas optimization report

[G-01] Make variables immutable

There are a few variables throughout the code base that is only assigned in the constructor, and then never assigned a new value - these can be marked as immutable to save some gas every time the variables are used.

File InifityToken.sol L31:

uint256 public currentEpochTimestamp;

File InfinityStaker.sol L25:

address public INFINITY_TOKEN;

[G-02] Cache variable to save gas

The state variable userMinOrderNonce[msg.sender] in the contract cancelAllOrders() can be cached to save gas on the expensive SLOAD operations.

File InfinityExchange.sol at L380-L381:

require(minNonce > userMinOrderNonce[msg.sender], 'nonce too low');
require(minNonce < userMinOrderNonce[msg.sender] + 1000000, 'too many');

As shown in the code example above, the state variable is read from storage twice, meaning two gas expensive SLOAD operations. Instead, we can cache the variable in memory, such that the 2 SLOAD operations will be converted into 1 SLOAD, 1 MSTORE and 2 MLOAD operations, which is cheaper.

This means the code can be changed into:

uint256 cachedNonce = userMinOrderNonce[msg.sender];
require(minNonce > cachedNonce, 'nonce too low');
require(minNonce < cachedNonce + 1000000, 'too many');

This will approximately save 152 gas

[G-03] Expressions in constants should be immutables

Using an expression like keccak256() in a constant will make the expression be evaluated each time the constant is used, which is the opposite of what we try to accomplish with a constant, and thus ends up costing more gas than needed.

Instead the variable should be marked as an immutable and assigned in the constructor, because then the expression is only evaluated once.

File InfinityToken.sol L25-L28:

bytes32 public constant EPOCH_INFLATION = keccak256('Inflation');
bytes32 public constant EPOCH_DURATION = keccak256('EpochDuration');
bytes32 public constant EPOCH_CLIFF = keccak256('Cliff');
bytes32 public constant MAX_EPOCHS = keccak256('MaxEpochs');

[G-04] Don’t initialize uint with 0

When declaring a uint it will have the value of 0 by default. This means that declaring a uint variable uint256 var = 0; will just use unnecessary gas and should instead just be uint256 var;.

Removing the assignment of 0 will save 8 gas and since this is done for almost every uint in the code base, the total amount of gas savings for this can be decent. A few examples: InfinityExchange L148:

for (uint256 i = 0; i < numMakerOrders; ) {

InfinityExchange L200:

for (uint256 i = 0; i < ordersLength; ) {

InfinityExchange L219:

for (uint256 i = 0; i < ordersLength; ) {

InfinityExchange L272:

for (uint256 i = 0; i < numSells; ) {

InfinityExchange L308:

for (uint256 i = 0; i < numMakerOrders; ) {