Infinity NFT Marketplace contest - sseefried's results

QA Report

Non-critical: require in getRageQuitAmounts does nothing

Line 93 is

require(totalStaked >= 0, 'nothing staked to rage quit');

This will never fail since totalStaked is a uint256. It should be

require(totalStaked > 0, 'nothing staked to rage quit');

However, this bug has no effect on the rageQuit function. The user and the treasury would have 0 tokens transferred to them and an event RageQuit(msg.sender, 0, 0) would be emmitted which has no ill effects.

Low Risk: Add a zero check on destination for InfinityExchange.rescueETH

Functoin rescueETH should have an additional line:

function rescueETH(address destination) external payable onlyOwner {
  require(destination != address(0));
  (bool sent, ) = destination.call{value: msg.value}('');
  require(sent, 'failed');
}

One wouldn't want to accidentally send the ETH to nowhere.