Yieldy contest - FudgyDRS's results

LOW - Staking.sol (lines 84-87) duplicate code (no side effects)

LOW - BatchRequests.sol (lines 73-75) ponential contract lock for external applications using getAddresses, as "contracts" array size gets very large the trasaction will have an increased likelihood of timing out (ie revert).

LOW - LiquidityReserve.sol (lines 92-98) setFee fee range can potentially be 100%, meaning possible for owner to honeypot.

LOW - Yieldy.sol (line 95) if _totalSupply is very large and _profit != 0, rebase will always fail. This is possible since role(MINTER_BURNER_ROLE) has unlimited access to mint and burn.

OPTIMIZATION - BatchRequests.sol (lines 19) sendWithdrawRequests - redundant test IStaking(contracts[i]).canBatchTransactions() is unnessicary since sendWithdrawlRequest already calls it. Becomes function sendWithdrawalRequests() external { uint256 contractsLength = contracts.length; for (uint256 i; i < contractsLength; ) { if ( contracts[i] != address(0)) { IStaking(contracts[i]).sendWithdrawalRequests(); } unchecked { ++i; } } }

OPTIMIZATION - BatchRequests.sol (all) contracts[] storage is more expensive to deploy and search is nessicary for changing data. Using mapping(address => bool) contracts makes more sense. Example contract revamp TBA

OPTIMIZATION - BatchRequests.sol (line 33) canBatchContract will save gas instantiating the value "batch" inside of the returns statement instead of a new variable: "returns(Batch[] memory batch)"

OPTIMIZATION - Staking.sol (lines 54-63) it's more efficent to not create a require statment than utilize the '&&' operator, write as: require(_stakingToken != address(0), "Invalid address"); require(_yieldyToken != address(0), "Invalid address"); require(_tokeToken != address(0), "Invalid address"); require(_tokePool != address(0), "Invalid address"); require(_tokeManager != address(0), "Invalid address"); require(_tokeReward != address(0), "Invalid address"); require(_liquidityReserve != address(0), "Invalid address");

OPTIMIZATION - Staking.sol lines(78-81) redundant if statement, already required _curvePool to be non-zero.

OPTIMIZATION - Staking.sol line(259-266) _isClaimAvailable will save gas instantiating the value "batch" inside of the returns statement instead of a new variable: "returns(Batch[] memory batch)"