Yieldy contest - ladboy233's results

https://github.com/code-423n4/2022-06-yieldy/blob/main/src/contracts/Staking.sol#L246

   function setTimeLeftToRequestWithdrawal(uint256 _timestamp)
        external
        onlyOwner
    {
        timeLeftToRequestWithdrawal = _timestamp;
    }

we can emit a event like other function did.

emit LogSetTimeLeftToRequestWithdrawl(uint256 ts);

Unchanged to state variable can be changed from public to immutable and constants

Since the contract uses an upgradeable contract, the developer separates the storage layout from the implementation.

In storage layout code, the unchanged state can be changed from public to immutable to save gas.

https://github.com/code-423n4/2022-06-yieldy/blob/main/src/contracts/StakingStorage.sol#L8

  address public TOKE_POOL;
    address public TOKE_MANAGER;
    address public TOKE_REWARD;
    address public STAKING_TOKEN;
    address public YIELDY_TOKEN;
    address public TOKE_TOKEN;
    address public LIQUIDITY_RESERVE;

all can be changed to immutable instead of public.

https://github.com/code-423n4/2022-06-yieldy/blob/main/src/contracts/StakingStorage.sol#L18

    address public COW_SETTLEMENT;
    address public COW_RELAYER;

the COW_SETTLEMENT and COW_RELAYER is set in staking constructor and never changed so, we can change from public to constants.

In Yieldly storage contract,

https://github.com/code-423n4/2022-06-yieldy/blob/main/src/contracts/YieldyStorage.sol#L7

  address public stakingContract; // immuable
   uint256 internal WAD; // immutable

stakingContract can be changed to immutable, WAS can be changed to constant.

https://github.com/code-423n4/2022-06-yieldy/blob/main/src/contracts/LiquidityReserveStorage.sol#L5

in LiquidityReserveStorage

    address public stakingToken; // staking token address
    address public rewardToken; // reward token address
    address public stakingContract; // staking contract address
     bool public isReserveEnabled; // ensures we are fully initialized

all can be set to immutable.

Use ternary operator to replace if else

https://github.com/code-423n4/2022-06-yieldy/blob/main/src/contracts/Staking.sol#L713

In function rebase in staking,

we can replace

   if (balance <= staked) {
                epoch.distribute = 0;
    } else {
                epoch.distribute = balance - staked;
    }

with

     epoch.distribute = balance <= staked ? 0 : balance - staked;

Reuse function to save gas

https://github.com/code-423n4/2022-06-yieldy/blob/main/src/contracts/LiquidityReserve.sol#L134

    function _calculateReserveTokenValue(uint256 _amount)
        internal
        view
        returns (uint256)

the function estimate the reserve token value as a helper function,

developer can use this _calculateReserveTokenValue function inside the function add Liquidity

https://github.com/code-423n4/2022-06-yieldy/blob/main/src/contracts/LiquidityReserve.sol#L104

function addLiquidity(uint256 _amount) external

to replace the duplicate logic in addLiqudity

https://github.com/code-423n4/2022-06-yieldy/blob/524f3b83522125fb7d4677fa7a7e5ba5a2c0fe67/src/contracts/LiquidityReserve.sol#L104

        uint256 stakingTokenBalance = IERC20Upgradeable(stakingToken).balanceOf(
            address(this)
        );
        uint256 rewardTokenBalance = IERC20Upgradeable(rewardToken).balanceOf(
            address(this)
        );
        uint256 lrFoxSupply = totalSupply();
        uint256 coolDownAmount = IStaking(stakingContract)
            .coolDownInfo(address(this))
            .amount;
        uint256 totalLockedValue = stakingTokenBalance +
            rewardTokenBalance +
            coolDownAmount;

        uint256 amountToMint = (_amount * lrFoxSupply) / totalLockedValue;

Function visibility can be external instead of public to save gas

https://github.com/code-423n4/2022-06-yieldy/blob/main/src/contracts/Staking.sol#L370

    function unstakeAllFromTokemak() public onlyOwner {

we can change the function visibility from public to external to save gas.