Yieldy contest - bardamu's results

> 0 is less efficient than != 0 for unsigned integers

!= 0 costs 6 less GAS compared to > 0 for unsigned integers in conditional statements with the optimizer enabled.

Use != 0 instead of > 0 in the following statements:

• if (amount > 0) IStaking(stakingContract).unstake(amount, false);
• if (amountToRequest > 0) tokePoolContract.requestWithdrawal(_amount);
• requestWithdrawalAmount > 0
• if (requestWithdrawalAmount > 0) {
• require(_amount > 0, "Must have valid amount");
• if (yieldyTotalSupply > 0) {
• if (info.credits > 0) {
• if (warmUpBalance > 0) {
• require(_amount > 0, "Invalid amount");
• require(_amount > 0, "Invalid amount");
• require(_totalSupply > 0, "Can't rebase if not circulating");
• require(rebasingCreditsPerToken > 0, "Invalid change in supply");

++i costs less gas compared to i++

++i costs less gas compared to i++ or i += 1 for unsigned integers. This is because the pre-increment operation is cheaper (about 5 GAS per iteration).

• Switch to pre-increment in epoch.number++;

Splitting require() statements that use && saves gas

Instead of using the && operator in a single require statement to check multiple conditions, using multiple require statements with 1 condition per require statement will save 3 GAS per &&.

• Split _stakingToken != address(0) && _rewardToken != address(0)
• Split _oldContract != address(0) && _newContract != address(0)
• Split _stakingToken != address(0) && _yieldyToken != address(0) && _tokeToken != address(0) && _tokePool != address(0) && _tokeManager != address(0) && _tokeReward != address(0) && _liquidityReserve != address(0)
• Split !isUnstakingPaused && !isInstantUnstakingPaused
• Split CURVE_POOL != address(0) && (curvePoolFrom == 1 || curvePoolTo == 1)
• Split !isUnstakingPaused && !isInstantUnstakingPaused