Yield Witch v2 contest - Funen's results

Fixed-rate borrowing and lending on Ethereum

General Information

Platform: Code4rena

Start Date: 14/07/2022

Pot Size: $25,000 USDC

Total HM: 2

Participants: 63

Period: 3 days

Judge: PierrickGT

Total Solo HM: 1

Id: 147

League: ETH

Yield

Findings Distribution

Researcher Performance

Rank: 42/63

Findings: 1

Award: $39.03

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

39.0318 USDC - $39.03

Labels

bug
QA (Quality Assurance)

External Links

  1. Lack of Validation

https://github.com/code-423n4/2022-07-yield/blob/6ab092b8c10e4dabb470918ae15c6451c861655f/contracts/Witch.sol#L95-L115

this was need to be check if duration != 0 or > 0, since

https://github.com/code-423n4/2022-07-yield/blob/6ab092b8c10e4dabb470918ae15c6451c861655f/contracts/Witch.sol#L92

/// @param duration Time that auctions take to go to minimal price

this duration Time maliciously can be set to be 0 and the function how much collateral is sold over time cant be do well enough.

  1. Missing Indexed

uint32 duration https://github.com/code-423n4/2022-07-yield/blob/6ab092b8c10e4dabb470918ae15c6451c861655f/contracts/Witch.sol#L46

  1. Important comment can be set on upper

this was an informational and important to set on upper, since it was important

https://github.com/code-423n4/2022-07-yield/blob/6ab092b8c10e4dabb470918ae15c6451c861655f/contracts/Witch.sol#L575-L578

// If the world has not turned to ashes and darkness, auctions will malfunction on // the 7th of February 2106, at 06:28:16 GMT // TODO: Replace this contract before then 😰 // UPDATE: Added reminder to Google calendar ✅

#0 - alcueca

2022-07-22T14:29:08Z

One useful

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter