Yield Witch v2 contest - rokinot's results

Fixed-rate borrowing and lending on Ethereum

General Information

Platform: Code4rena

Start Date: 14/07/2022

Pot Size: $25,000 USDC

Total HM: 2

Participants: 63

Period: 3 days

Judge: PierrickGT

Total Solo HM: 1

Id: 147

League: ETH

Yield

Findings Distribution

Researcher Performance

Rank: 26/63

Findings: 2

Award: $56.13

🌟 Selected for report: 0

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository Yield

Findings Information

🌟 Selected for report: hickuphh3

Also found by: 0x29A, 0x52, 0xNazgul, Chom, Deivitto, ElKu, Funen, IllIllI, Meera, ReyAdmirado, SooYa, TomJ, Trumpero, Waze, __141345__, ak1, asutorufos, c3phas, cRat1st0s, csanuragjain, delfin454000, exd0tpy, fatherOfBlocks, hake, hansfriese, horsefacts, hyh, karanctf, kenzo, kyteg, ladboy233, pashov, peritoflores, rajatbeladiya, rbserver, reassor, rokinot, simon135, wastewa

Awards

39.2456 USDC - $39.25

Labels

bug

QA (Quality Assurance)

External Links

Link to GitHub issue

Non-critical

Typos #L520

Redudant uint128() as function already returns type uint128 #L303

#0 - alcueca
2022-07-22T14:48:55Z

Thanks, two useful

Findings Information

🌟 Selected for report: IllIllI

Also found by: 0x1f8b, 0x29A, 0xKitsune, 0xNazgul, Aymen0909, Chom, Deivitto, ElKu, JC, JohnSmith, Kaiziron, Limbooo, MadWookie, Meera, ReyAdmirado, Rohan16, Sm4rty, SooYa, TomJ, Trumpero, Waze, __141345__, ajtra, ak1, antonttc, bulej93, c3phas, cRat1st0s, csanuragjain, defsec, durianSausage, fatherOfBlocks, gogo, hake, hickuphh3, ignacio, joestakey, karanctf, kyteg, m_Rassska, pashov, rajatbeladiya, rbserver, robee, rokinot, samruna, sashik_eth, simon135, tofunmi

Awards

16.8778 USDC - $16.88

Labels

bug

G (Gas Optimization)

External Links

Link to GitHub issue

Use `x = x + y` instead of `x += y` for lower gas usage, same as `x = x - y` instead of `x -= y`

#L204 #L259 #L430 #L443-L444 #L450 #L598

Use `x != 0` instead of `x > 0` for unsigned integer comparisons

#L255 #L300 #L358 #L393 #L398 #L416

Yield Witch v2 contest - rokinot's results

Fixed-rate borrowing and lending on Ethereum

General Information

Findings Distribution

Researcher Performance

External Links

[Q-36] QA Report - $39.25

Findings Information

Awards

Labels

External Links

Non-critical

#0 - alcueca2022-07-22T14:48:55Z

[G-50] Gas Report - $16.88

Findings Information

Awards

Labels

External Links

Use x = x + y instead of x += y for lower gas usage, same as x = x - y instead of x -= y

Use x != 0 instead of x > 0 for unsigned integer comparisons

#0 - alcueca
2022-07-22T14:48:55Z

Use `x = x + y` instead of `x += y` for lower gas usage, same as `x = x - y` instead of `x -= y`

Use `x != 0` instead of `x > 0` for unsigned integer comparisons