Yield Witch v2 contest - karanctf's results

Fixed-rate borrowing and lending on Ethereum

General Information

Platform: Code4rena

Start Date: 14/07/2022

Pot Size: $25,000 USDC

Total HM: 2

Participants: 63

Period: 3 days

Judge: PierrickGT

Total Solo HM: 1

Id: 147

League: ETH

Yield

Findings Distribution

Researcher Performance

Rank: 24/63

Findings: 2

Award: $56.46

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

39.5894 USDC - $39.59

Labels

bug
QA (Quality Assurance)
sponsor confirmed

External Links

WRONG ERROR MESSAGE STRING IN FUNCTION auction()

Line200: require(limits_.sum <= limits_.max, "Collateral limit reached");

https://github.com/code-423n4/2022-07-yield/blob/6ab092b8c10e4dabb470918ae15c6451c861655f/contracts/Witch.sol#L200

The above error massage would be relevent if it was only less then not less then or equal

Correct error message string

Line200: require(limits_.sum <= limits_.max, "Collateral limit exceeded");

#0 - alcueca

2022-07-22T14:28:17Z

True, thank you.

++i costs less gas than i++, especially when it's used in for-loops (--i/i-- too)

 Line25: for (uint256 i = 0; i < userNum; i++) {

https://github.com/code-423n4/2022-07-yield/blob/6ab092b8c10e4dabb470918ae15c6451c861655f/contracts/test/utils/Utilities.sol#L25

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter