Behodler contest - IllIllI's results

Handle

IllIllI

Vulnerability details

Impact

When the value of the post-loop increment/decrement is not stored or used in any calculations, the prefix increment/decrement operators (++i/--i) cost less gas PER LOOP than the postfix increment/decrement operators (i++/i--)

Proof of Concept

There are five examples of this issue in the codebase:

for (uint256 i = 0; i < tokens.length; i++) approvedTokens[tokens[i]] = value;    

https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/testing/MockMorgothTokenApprover.sol#L9

for (uint256 i = 0; i < LPs.length; i++) {      

https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/testing/MockToken.sol#L15

for (uint256 i = 0; i < sushiLPs.length; i++) {      

https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L212

for (uint256 i = 0; i < uniLPs.length; i++) {      

https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L217

for (uint256 i = 0; i < params.length; i++) {      

https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/Proposals/UpdateMultipleSoulConfigProposal.sol#L64

Tools Used

Code inspection

Recommended Mitigation Steps

Use ++i rather than i++ in all places