Platform: Code4rena
Start Date: 27/01/2022
Pot Size: $90,000 USDC
Total HM: 21
Participants: 33
Period: 7 days
Judge: Jack the Pug
Total Solo HM: 14
Id: 78
League: ETH
Rank: 21/33
Findings: 1
Award: $206.31
🌟 Selected for report: 1
🚀 Solo Findings: 0
🌟 Selected for report: Dravee
Also found by: CertoraInc, defsec, pauliax, sirhashalot
22.9602 USDC - $22.96
defsec
For the arithmetic operations that will never over/underflow, using the unchecked directive (Solidity v0.8 has default overflow/underflow checks) can save some gas from the unnecessary internal over/underflow checks.
https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L424
None
Consider applying unchecked arithmetic where overflow/underflow is not possible.
#0 - gititGoro
2022-02-10T04:41:56Z
duplicate of issue 116
#1 - jack-the-pug
2022-02-22T15:48:51Z
Dup #265
defsec
++i is more gas efficient than i++ in loops forwarding.
https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L212 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L217
Code Review
It is recommend to use unchecked{++i} and change i declaration to uint256.
#0 - gititGoro
2022-02-10T00:03:00Z
duplicate of issue 10
#1 - jack-the-pug
2022-02-22T14:47:50Z
Dup #10
🌟 Selected for report: defsec
174.9751 USDC - $174.98
defsec
The use of _msgSender() when there is no implementation of a meta transaction mechanism that uses it, such as EIP-2771, very slightly increases gas consumption.
_msgSender() is utilized three times where msg.sender could have been used in the following function.
https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L251 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L288 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L291 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L330 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L387 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L151
None
Replace _msgSender() with msg.sender if there is no mechanism to support meta-transactions like EIP-2771 implemented.
#0 - gititGoro
2022-02-05T02:12:57Z
I haven't made a final decision on the _msgSender() usage.