Popcorn contest - Inspectah's results

Low and Non-Critical Issues

Function visibility can be set to view

Instances:

• VaultController.sol

  L-242

  function _encodeAdapterData(DeploymentArgs memory adapterData, bytes memory baseAdapterData internal
      returns (bytes memory)

  L-667

  function _verifyCreatorOrOwner(address vault) internal returns (VaultMetadata memory metadata) {

Unused parameter

Instances

• VaultController.sol

  L-390

  address vault argument is not used in the function.

  function _registerVault(address vault, VaultMetadata memory metadata) internal {

Unused local variable

• Vault.sol

function accruedPerformanceFee() public view returns (uint256) {
        uint256 highWaterMark_ = highWaterMark;
        uint256 shareValue = convertToAssets(1e18);
        uint256 performanceFee = fees.performance;

        return
            performanceFee > 0 && shareValue > highWaterMark
                ? performanceFee.mulDiv(
                    (shareValue - highWaterMark) * totalSupply(),
                    1e36,
                    Math.Rounding.Down
                )
                : 0;
    }

State variable highWaterMark is copied to a local variable highWaterMark_but the function uses the state variable to read the value.

Success of delegateCall not checked

• AdapterBase.sol

address(strategy).delegatecall(
                abi.encodeWithSignature("harvest()")
            );
        }
emit Harvested();

Delegate call returns 2 values. The first one being the success of the transaction and the second is the return data. Success of the delegate call is not checked before emitting the Harvested event