Popcorn contest - olegthegoat's results

A multi-chain regenerative yield-optimizing protocol.

General Information

Platform: Code4rena

Start Date: 31/01/2023

Pot Size: $90,500 USDC

Total HM: 47

Participants: 169

Period: 7 days

Judge: LSDan

Total Solo HM: 9

Id: 211

League: ETH

Popcorn

Findings Distribution

Researcher Performance

Rank: 130/169

Findings: 1

Award: $35.48

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

QA Report

One issue was found with low impact.

L01 - setPermissions function not checking for valid boolean

On line 43 in PermissionRegistry.sol, the only check that exists is making sure that the user doesn't have both permissions set to true for endorsed and rejected. The code is not taking into account that it is possible to pass down other value types that are NOT boolean. If endorsed and rejected are set to another value that is not true or false, it could result in unexpected behavior.

Impact:

LOW

Tool used:

Manual Analysis

Mitigation:

  • In PermissionRegistry.sol, before Line 43 inside the for loop, add validation to see if both rejected and endorsed are valid booleans.

Affected Code: https://github.com/code-423n4/2023-01-popcorn//blob/main/src/vault/PermissionRegistry.sol#L43

#0 - c4-judge

2023-02-28T13:14:36Z

dmvt marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter