Popcorn contest - climber2002's results

A multi-chain regenerative yield-optimizing protocol.

General Information

Platform: Code4rena

Start Date: 31/01/2023

Pot Size: $90,500 USDC

Total HM: 47

Participants: 169

Period: 7 days

Judge: LSDan

Total Solo HM: 9

Id: 211

League: ETH

Popcorn

Findings Distribution

Researcher Performance

Rank: 129/169

Findings: 1

Award: $35.48

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

Certain events or errors are never used and can be deleted

  1. The error NotEndorsed(bytes32 templateKey) defined in CloneFactory.sol is never used and can be deleted.

  2. The event TemplateUpdated defined in TemplateRegistry.sol is never used

Some functions can be restricted to view mutability

  1. StrategyBase.verifyAdapterSelectorCompatibility, from the method name it shouldn't change contract state

  2. VaultController. _encodeAdapterData

fees_ param is not validated in Vault.initialize

The fees param is validated in proposeFees but in initialize the param is not validated.

We can extract a _validateFees internal function and call it in two places.

#0 - c4-judge

2023-03-01T00:21:29Z

dmvt marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter