Trader Joe v2 contest - M4TZ1P's results

Judge has assessed an item in Issue #381 as M risk. The relevant finding follows:

There is no limit for FlashLoanFee function setFlashLoanFee(uint256 _flashLoanFee) external override onlyOwner { uint256 _oldFlashLoanFee = flashLoanFee;

    if (_oldFlashLoanFee == _flashLoanFee) revert LBFactory__SameFlashLoanFee(_flashLoanFee);

    flashLoanFee = _flashLoanFee;
    emit FlashLoanFeeSet(_oldFlashLoanFee, _flashLoanFee);
}

https://github.com/code-423n4/2022-10-traderjoe/blob/79f25d48b907f9d0379dd803fc2abc9c5f57db93/src/LBFactory.sol#L479

There is no limit for FlashLoanFee. So Owner of LBFactory could set FlashLoanFee extreamly high.

Check flashLoanFee is lower than MAX_FEE when setFlashLoanFee and constructor of LBFactory.