Trader Joe v2 contest - csanuragjain's results

Judge has assessed an item in Issue #70 as M risk. The relevant finding follows:

Flash loan fee can be set to 100% Contract: https://github.com/code-423n4/2022-10-traderjoe/blob/main/src/LBFactory.sol#L474

Issue: In setFlashLoanFee function, If Admin has set flashloan fee to 100% then user taking X amount as flashloan has to pay a fee equal to X which does not make sense

function setFlashLoanFee(uint256 _flashLoanFee) external override onlyOwner { uint256 _oldFlashLoanFee = flashLoanFee;

    if (_oldFlashLoanFee == _flashLoanFee) revert LBFactory__SameFlashLoanFee(_flashLoanFee);

    flashLoanFee = _flashLoanFee;
    emit FlashLoanFeeSet(_oldFlashLoanFee, _flashLoanFee);
}

Recommendation: Implement a upper bound on flashloan fee