Trader Joe v2 contest - leosathya's results

One-stop-shop decentralized trading on Avalanche.

General Information

Platform: Code4rena

Start Date: 14/10/2022

Pot Size: $100,000 USDC

Total HM: 12

Participants: 75

Period: 9 days

Judge: GalloDaSballo

Total Solo HM: 1

Id: 171

League: ETH

Trader Joe

Findings Distribution

Researcher Performance

Rank: 71/75

Findings: 1

Award: $0.01

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

0.006 USDC - $0.01

Labels

2 (Med Risk)
satisfactory
duplicate-139

External Links

Judge has assessed an item in Issue #194 as M risk. The relevant finding follows:

[L-04] Should be a upper-bound on Flash-loan fee There are 1 instances of this issue:

** File : ** => https://github.com/code-423n4/2022-10-traderjoe/blob/main/src/LBFactory.sol#L63-L-68

Recommended Mitigation There should be a upper bound of Flash-loan fee define in contract so that owner can't able to set fee more than that value.

[L-05] Centralization :: Owner can change flashloan fee anytime, which can result cause of front-running There are 1 instances of this issue:

** File : ** => https://github.com/code-423n4/2022-10-traderjoe/blob/main/src/LBFactory.sol#L63-L-68

Recommended Mitigation There should be a DAO or a timelock system that help user to decide whether they are ok with fee or not.

#0 - c4-judge

2022-11-14T23:18:30Z

GalloDaSballo marked the issue as duplicate of #139

#1 - Simon-Busch

2022-12-05T06:31:26Z

Marked this issue as Satisfactory as requested by @GalloDaSballo

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter