LooksRare Aggregator contest - Nyx's results

An NFT aggregator protocol.

General Information

Platform: Code4rena

Start Date: 08/11/2022

Pot Size: $60,500 USDC

Total HM: 6

Participants: 72

Period: 5 days

Judge: Picodes

Total Solo HM: 2

Id: 178

League: ETH

LooksRare

Findings Distribution

Researcher Performance

Rank: 64/72

Findings: 1

Award: $36.34

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

Lines of code

https://github.com/code-423n4/2022-11-looksrare/blob/e3b2c053f722b0ca2dce3a3eb06f64859b8b7a6f/contracts/TokenTransferrer.sol#L22

Vulnerability details

Impact

It is recommended to use safeTransferFrom() instead of transferFrom() when transferring ERC721. The recipient could have logic in the onERC721Received() function, which is only triggered in the safeTransferFrom() function and not in transferFrom(). There is the potential loss of NFTs If the recipient is unable to handle the sent ERC721s.

Proof of Concept

https://github.com/code-423n4/2022-11-looksrare/blob/e3b2c053f722b0ca2dce3a3eb06f64859b8b7a6f/contracts/TokenTransferrer.sol#L22

Tools Used

Manuel Review

Use safeTransferFrom() when sending out the NFTs.

#0 - c4-judge

2022-11-21T15:18:14Z

Picodes marked the issue as duplicate of #174

#1 - c4-judge

2022-12-11T16:35:03Z

Picodes marked the issue as not a duplicate

#2 - c4-judge

2022-12-11T16:35:15Z

Picodes changed the severity to QA (Quality Assurance)

#3 - c4-judge

2022-12-11T16:35:47Z

Picodes marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter