LooksRare Aggregator contest - a12jmx's results

An NFT aggregator protocol.

General Information

Platform: Code4rena

Start Date: 08/11/2022

Pot Size: $60,500 USDC

Total HM: 6

Participants: 72

Period: 5 days

Judge: Picodes

Total Solo HM: 2

Id: 178

League: ETH

LooksRare

Findings Distribution

Researcher Performance

Rank: 57/72

Findings: 1

Award: $36.34

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

36.3434 USDC - $36.34

Labels

bug
grade-b
judge review requested
QA (Quality Assurance)
sponsor confirmed
Q-41

External Links

Grammer issues in comments in:

1.1

Contract: ILooksRareAggregator.sol

1.1.1

line 21 "hardcoded" should be two words "hard coded"

Modified Comment:

* @param originator The address that originated the transaction, hard coded as msg.sender if it is called directly

1.2

Contract: SeaportInterface.sol

1.2.1

lines 83, and 191 "offer" should be "offers"

Modified Comments:

* Also note that all offers and consideration * note that all offers and consideration

1.2.2

line 94 "indicates" should be "indicate"

Modified Comment:

* empty criteria indicate that any

1.2.3

lines 96, and 295 the "that" before "no" is unnecessary

Modified Comments:

* in question is valid and no associated * token identifier is valid and no associated

1.2.4

line 362 the "the" before "fraction" should be "a"

Modified Comment:

* the order has been cancelled or validated and a fraction of the

1.3

Contract: ConsiderationStructs.sol

1.3.1

line 41 "support" should be "supports"

Modified Comment:

* depending on the item type, and a start and end amount that supports

1.3.2

line 168 "are" should be "is"

Modified Comment:

* type is restricted and the offerer or zone is not the caller.

1.3.3

line 209 "offer" should be "offers"

Modified Comment:

* element. A given fulfillment can be applied to as many offers and

1.4

Contract: LooksRareProxy.sol

1.4.1

line 18 "batch buy" should be hyphenated as "batch-buy"

Modified Comment:

* @notice This contract allows NFT sweepers to batch-buy NFTs from LooksRare

1.5

Contract: LooksRareAggregator.sol

1.5.1

line 39 "to" before the last "this" should be "for"

Modified Comment:

* this contract's ownership is compromised. By not providing any allowances for this

1.6

Contract: SignatureChecker.sol

1.6.1

line 9 "length" should be "lengths"

Modified Comment:

* @notice This contract is used to verify signatures for EOAs (with lengths of both 65 and 64 bytes) and contracts (ERC-1271).

1.6.2

line 59 "signer" should be "signer's"

Modified Comment:

// If the signature is valid (and not malleable), return the signer's address

2.

Two unnecessary lines open at the beginning of the contract LowLevelERC20Transfer.sol between the start of the contract and the License-Identifier.

Consider removing the two unnecessary open lines and starting the License-Identifier in line 1 as a best practice.

This will also bring consistency to all contracts under scope.

#0 - c4-judge

2022-11-21T17:32:43Z

Picodes marked the issue as grade-b

#1 - 0xhiroshi

2022-11-24T22:19:36Z

Won't fix for Seaport files, but will fix the other typos / grammatical mistakes.

#2 - c4-sponsor

2022-11-24T22:19:42Z

0xhiroshi marked the issue as sponsor confirmed

#3 - 0xhiroshi

2022-11-25T09:01:59Z

Actually "hardcoded" should also be valid

#4 - c4-sponsor

2022-11-25T09:02:27Z

0xhiroshi requested judge review

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter