LooksRare Aggregator contest - adriro's results

An NFT aggregator protocol.

General Information

Platform: Code4rena

Start Date: 08/11/2022

Pot Size: $60,500 USDC

Total HM: 6

Participants: 72

Period: 5 days

Judge: Picodes

Total Solo HM: 2

Id: 178

League: ETH

LooksRare

Findings Distribution

Researcher Performance

Rank: 62/72

Findings: 1

Award: $36.34

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

Duplicate imports in LooksRareAggregator contract

  • BasicOrder
  • TokenTransfer
  • LooksRareProxy
  • TokenReceiver
  • TokenRescuer

Unused imports in LooksRareAggregator contract

  • BasicOrder
  • LooksRareProxy

Unused imports in LooksRareProxy contract

  • IERC721
  • IERC1155
  • FeeData

Unused imports in SeaPortProxy contract

  • IERC20
  • CollectionType
  • FeeData

value member in TradeData struct isn't used in the codebase

The comment associated to this field reads "The amount of ETH passed to the proxy during the function call", however proxies are delegatecalled, there's no need to send ETH. This is likely a field that was used at certain point in the codebase .

#0 - c4-judge

2022-11-21T17:12:23Z

Picodes marked the issue as grade-b

#1 - c4-sponsor

2022-11-24T18:08:30Z

0xhiroshi marked the issue as sponsor confirmed

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter