FEI and TRIBE Redemption contest - R2's results

A new DeFi primitive that allows any token to become productive and provide FEI liquidity at no cost to the markets that need it most.

General Information

Platform: Code4rena

Start Date: 09/09/2022

Pot Size: $42,000 USDC

Total HM: 2

Participants: 101

Period: 3 days

Judge: hickuphh3

Total Solo HM: 2

Id: 161

League: ETH

Tribe

Findings Distribution

Researcher Performance

Rank: 8/101

Findings: 1

Award: $81.81

🌟 Selected for report: 0

🚀 Solo Findings: 0

1. No modifier hasNotSigned in RariMerkleRedeemer.signAndClaim()

2. How to update RariMerkleRedeemer

Desctiption

You are deploying RariMerkleRedeemer with merkleRoots, representing current state But then new users can deposit funds to your pools. How can they get their money back? Should they wait before you will deploy another RariMerkleRedeemer with new state (merkleRoots)?

3. No checks that all tokens in TribeRedeemer have the same decimals()

Desctiption

Decimals for redeemedToken and each of tokensReceived may be different. It will break contract logic. So check it in constructor

4. No checks that tokens in TribeRedeemer are not address(0)

5. Check redeemedToken, do not use amountIn

If you will use deflationary token or fee token as a redeemedToken, your logic will fail In TribeRedeemer.redeem() you are using amountIn to calculate previewRedeem() But on your balance you may receive tokens less then amountIn

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter