FEI and TRIBE Redemption contest - __141345__'s results

A new DeFi primitive that allows any token to become productive and provide FEI liquidity at no cost to the markets that need it most.

General Information

Platform: Code4rena

Start Date: 09/09/2022

Pot Size: $42,000 USDC

Total HM: 2

Participants: 101

Period: 3 days

Judge: hickuphh3

Total Solo HM: 2

Id: 161

League: ETH

Tribe

Findings Distribution

Researcher Performance

Rank: 39/101

Findings: 1

Award: $33.60

🌟 Selected for report: 0

🚀 Solo Findings: 0

AVOID FLOATING PRAGMAS: THE VERSION SHOULD BE LOCKED

The pragma declared across the solution is ^0.8.4 and =0.8.10. Locking the pragma (for e.g. by not using ^ in pragma solidity 0.8.10) ensures that contracts do not accidentally get deployed using an older compiler version with unfixed bugs. (see here)

Typo

"int he" should be "in the".

contracts/shutdown/fuse/RariMerkleRedeemer.sol

164:    /// Should set the user's claim amount int he claims mapping for the provided cToken
EVENT IS MISSING INDEXED FIELDS

Each event should use three indexed fields if there are three or more fields.

contracts/peg/SimpleFeiDaiPSM.sol
27:     event Redeem(address to, uint256 amountFeiIn, uint256 amountAssetOut);
29:     event Mint(address to, uint256 amountIn, uint256 amountFeiOut);

contracts/shutdown/redeem/TribeRedeemer.sol
14:     event Redeemed(address indexed owner, address indexed receiver, uint256 amount, uint256 base);
Use custom errors

Custom error can be used, they are cheaper at deployment than revert()/require() strings.

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter