FEI and TRIBE Redemption contest - sikorico's results

QA REPORT

[QA 00] Use SafeMath in the following contracts to avoid unexpected overflow/underflow

Proof of concept:

• DSTest.sol

[QA 01] The following require statements are missing an error message

Proof of concept:

• BalancerPool2Lens.sol#L72
• BPTLens.sol#L61

[QA 02] Some tokens needs approve 0 before any approve above 0

Consider using increase/decrease approve notation instead approve to deal with that.

Proof of concept:

• rariMerkleRedeemer.t.sol#L663
• NonCustodialPSM.t.sol#L148
• CurvePCVDepositPlainPool.sol#L87
• BalancerLBPSwapper.sol#L176
• TribeRedeemer.t.sol#L80

[QA 03] Missing MIT licence for the following contracts

Proof of concept:

• BalanceGuard.sol
• MultiActionGuard.sol
• GOhmEthOracle.t.sol
• SmartYieldRedeemer.sol
• OwnableTimedMinter.sol

[QA 04] Remove the name from the following unused function parameters

Proof of concept:

• PegStabilityModule.sol#L386
• AutoRewardsDistributorV2.sol#L54
• NopeDAO.sol#L37
• VotiumBriber.sol#L34
• TribeRagequit.sol#L51

[QA 05] Not emitted event for state changes

Proof of concept:

• NopeDAO.t.sol#L38
• NopeDAO.t.sol#L52
• AutoRewardsDistributorV2.sol#L54
• VotiumBriber.sol#L34
• RestrictedPermissions.sol#L23

[QA 06] Both return statement and named return

For readability purposes consider having one of the two return options (for the following functions)

Proof of concept:

• ConvexPCVDeposit.sol#L113
• BalanceGuard.sol#L23
• MaxFeiWithdrawalGuard.sol#L97
• RecoverEthGuard.sol#L20
• BalancerPCVDepositWeightedPool.sol#L123