ENS contest - ReyAdmirado's results

Decentralised naming for wallets, websites, & more.

General Information

Platform: Code4rena

Start Date: 12/07/2022

Pot Size: $75,000 USDC

Total HM: 16

Participants: 100

Period: 7 days

Judge: LSDan

Total Solo HM: 7

Id: 145

League: ETH

ENS

Findings Distribution

Researcher Performance

Rank: 63/100

Findings: 2

Award: $118.74

🌟 Selected for report: 0

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository ENS

Findings Information

🌟 Selected for report: IllIllI

Also found by: 0x1f8b, 0x29A, 0xDjango, 0xNazgul, 0xNineDec, 0xf15ers, 8olidity, Aussie_Battlers, Bnke0x0, Ch_301, Critical, Deivitto, Dravee, ElKu, Funen, GimelSec, JC, JohnSmith, Lambda, MiloTruck, PwnedNoMore, ReyAdmirado, Rohan16, Rolezn, Ruhum, RustyRabbit, Sm4rty, TomJ, Waze, _Adam, __141345__, alan724, asutorufos, benbaessler, berndartmueller, bin2chen, brgltd, bulej93, c3phas, cRat1st0s, cryptonue, cryptphi, csanuragjain, delfin454000, dxdv, exd0tpy, fatherOfBlocks, gogo, hake, hyh, joestakey, kyteg, lcfr_eth, minhtrng, p_crypt0, pashov, pedr02b2, philogy, rajatbeladiya, rbserver, rishabh, robee, rokinot, sach1r0, sashik_eth, seyni, simon135, svskaushik, zuhaibmohd, zzzitron

Awards

78.8739 USDC - $78.87

Labels

bug

QA (Quality Assurance)

External Links

Link to GitHub issue

typo in comments:

optimised --> optimized

ReverseRegistrar.sol#L156

PARENT_CANOT_CONTROL --> PARENT_CANNOT_CONTROL

NameWrapper.sol#L370

regsitry --> registry

NameWrapper.sol#L534

Findings Information

🌟 Selected for report: 0xKitsune

Also found by: 0x040, 0x1f8b, 0x29A, 0xNazgul, 0xNineDec, 0xsam, 8olidity, Aussie_Battlers, Aymen0909, Bnke0x0, CRYP70, Ch_301, Chom, Deivitto, Dravee, ElKu, Fitraldys, Funen, GimelSec, IllIllI, JC, JohnSmith, Lambda, MiloTruck, Noah3o6, RedOneN, ReyAdmirado, Rohan16, Rolezn, Ruhum, Sm4rty, TomJ, Tomio, Waze, _Adam, __141345__, ajtra, ak1, arcoun, asutorufos, benbaessler, brgltd, bulej93, c3phas, cRat1st0s, cryptonue, delfin454000, durianSausage, fatherOfBlocks, gogo, hake, hyh, joestakey, karanctf, kyteg, lcfr_eth, lucacez, m_Rassska, rajatbeladiya, rbserver, robee, rokinot, sach1r0, sahar, samruna, sashik_eth, seyni, simon135, zuhaibmohd

Awards

39.8689 USDC - $39.87

Labels

bug

G (Gas Optimization)

External Links

Link to GitHub issue

1. it costs more gas to initialize variables to zero than to let the default of zero be applied

2. can make the variable outside the loop to save gas

3. `<array>.length` should not be looked up in every loop of a for-loop

4. x = x + y is cheaper than x += y

5. better to use `++i` than `i++`

6. use custom errors rather than revert()/require() strings to save deployment gas

https://blog.soliditylang.org/2021/04/21/custom-errors/

ENS contest - ReyAdmirado's results

Decentralised naming for wallets, websites, & more.

General Information

Findings Distribution

Researcher Performance

External Links

Findings Information

Awards

Labels

External Links

typo in comments:

Findings Information

Awards

Labels

External Links

1. it costs more gas to initialize variables to zero than to let the default of zero be applied

2. can make the variable outside the loop to save gas

3. `<array>.length` should not be looked up in every loop of a for-loop

4. x = x + y is cheaper than x += y

5. better to use `++i` than `i++`

6. use custom errors rather than revert()/require() strings to save deployment gas

7.Use a solidity version of at least 0.8.10 to have external calls skip contract existence checks if the external call has a return value

8. require()/revert() strings longer than 32 bytes cost extra gas

ENS contest - ReyAdmirado's results

Decentralised naming for wallets, websites, & more.

General Information

Findings Distribution

Researcher Performance

External Links

[Q-69] QA Report - $78.87

Findings Information

Awards

Labels

External Links

typo in comments:

[G-54] Gas Report - $39.87

Findings Information

Awards

Labels

External Links

1. it costs more gas to initialize variables to zero than to let the default of zero be applied

2. can make the variable outside the loop to save gas

3. <array>.length should not be looked up in every loop of a for-loop

4. x = x + y is cheaper than x += y

5. better to use ++i than i++

6. use custom errors rather than revert()/require() strings to save deployment gas

7.Use a solidity version of at least 0.8.10 to have external calls skip contract existence checks if the external call has a return value

8. require()/revert() strings longer than 32 bytes cost extra gas

3. `<array>.length` should not be looked up in every loop of a for-loop

5. better to use `++i` than `i++`