ENS contest - pedr02b2's results

Decentralised naming for wallets, websites, & more.

General Information

Platform: Code4rena

Start Date: 12/07/2022

Pot Size: $75,000 USDC

Total HM: 16

Participants: 100

Period: 7 days

Judge: LSDan

Total Solo HM: 7

Id: 145

League: ETH

ENS

Findings Distribution

Researcher Performance

Rank: 76/100

Findings: 1

Award: $78.88

🌟 Selected for report: 0

🚀 Solo Findings: 0

Explicitly mark the visibilty of state variables

RRUtils.sol

lines 63-70 https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/dnssec-oracle/RRUtils.sol#L63

lines 181-184 https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/dnssec-oracle/RRUtils.sol#L181

lines 200-203 https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/dnssec-oracle/RRUtils.sol#L200

ETHRgistrarController.sol

https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/ethregistrar/ETHRegistrarController.sol#L49

Missing SPDX-License-Identifier

SHA1.sol

BytesUtils.sol

Owned.sol

RRUtils.sol

Digest.sol

ETHRegistrarController.sol

ReverseRegistrar.sol

IMetaDataService.sol

ENS.sol

Natspec

Incomplete/missing natspec, some files contain a comprehensive natspec, some files contain no natspec atall, some files contain @dev comments but no other comments such as function @param or @returns just for example.

BytesUtils.sol

RRUtils.sol

SHA1.sol lines 5-37

Owned.sol lines 6-22

DNSSEC.sol lines 4-20

ETHRegistrarController.sol

IETHRegistrarController.sol

IBaseRegistrar.sol

INameWrapper.sol

Controllable.sol

IMetaDataService.sol

ENS.sol

Unrequired Constructor Visibility

Remove the visibility for the constructor in Owned.sol

https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/dnssec-oracle/Owned.sol#L14

line 14 constructor() public {

sincev0.7.0 the visibility for constructors no longer needs to be explicitly stated

Visibility (public / internal) is not needed for constructors anymore: To prevent a contract from being created, it can be marked abstract. This makes the visibility concept for constructors obsolete.

https://docs.soliditylang.org/en/v0.8.15/070-breaking-changes.html?highlight=construcor%20visibility#functions-and-events

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter