Fractional v2 contest - ReyAdmirado's results

A collective ownership platform for NFTs on Ethereum.

General Information

Platform: Code4rena

Start Date: 07/07/2022

Pot Size: $75,000 USDC

Total HM: 32

Participants: 141

Period: 7 days

Judge: HardlyDifficult

Total Solo HM: 4

Id: 144

League: ETH

Fractional

Findings Distribution

Researcher Performance

Rank: 66/141

Findings: 2

Award: $103.79

🌟 Selected for report: 0

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository Fractional

Findings Information

🌟 Selected for report: xiaoming90

Also found by: 0x1f8b, 0x29A, 0x52, 0xA5DF, 0xDjango, 0xNazgul, 0xNineDec, 0xf15ers, 0xsanson, 0xsolstars, 242, 8olidity, Amithuddar, Aymen0909, Bnke0x0, BowTiedWardens, David_, Deivitto, ElKu, Funen, Hawkeye, IllIllI, JC, Kaiziron, Keen_Sheen, Kthere, Kulk0, Kumpa, Lambda, MEP, ReyAdmirado, Rohan16, Ruhum, Sm4rty, TomJ, Tomio, Treasure-Seeker, TrungOre, Tutturu, Viksaa39, Waze, _Adam, __141345__, ak1, apostle0x01, asutorufos, async, ayeslick, aysha, bbrho, benbaessler, berndartmueller, c3phas, cccz, chatch, cloudjunky, codexploder, cryptphi, delfin454000, dipp, durianSausage, dy, exd0tpy, fatherOfBlocks, hake, hansfriese, horsefacts, hubble, joestakey, jonatascm, kebabsec, kenzo, kyteg, mektigboy, neumo, oyc_109, pashov, pedr02b2, peritoflores, rajatbeladiya, rbserver, robee, rokinot, s3cunda, sach1r0, sahar, sashik_eth, scaraven, shenwilly, simon135, sorrynotsorry, sseefried, svskaushik, unforgiven, z3s, zzzitron

Awards

61.9379 USDC - $61.94

Labels

bug

QA (Quality Assurance)

sponsor disputed

External Links

Link to GitHub issue

typo in comments

succesful --> successful

propoal --> proposal

IMigration.sol#L25

falsey --> false

ITransfer.sol#L25

Udpates --> Updates

Migration.sol#L322

attemping --> attempting

SafeSend.sol#L15

Findings Information

🌟 Selected for report: joestakey

Also found by: 0x1f8b, 0x29A, 0xA5DF, 0xKitsune, 0xNazgul, 0xNineDec, 0xalpharush, 0xkatana, 0xsanson, 0xsolstars, 8olidity, Avci, Bnke0x0, BowTiedWardens, Chom, Deivitto, ElKu, Fitraldys, Funen, IllIllI, JC, Kaiziron, Lambda, Limbooo, MEP, NoamYakov, PwnedNoMore, RedOneN, ReyAdmirado, Rohan16, Ruhum, Saintcode_, Sm4rty, TomJ, Tomio, TrungOre, Tutturu, Waze, _Adam, __141345__, ajtra, apostle0x01, asutorufos, benbaessler, brgltd, c3phas, codexploder, cryptphi, delfin454000, dharma09, djxploit, durianSausage, fatherOfBlocks, giovannidisiena, gogo, horsefacts, hrishibhat, hyh, ignacio, jocxyen, jonatascm, karanctf, kebabsec, kyteg, m_Rassska, mektigboy, oyc_109, pedr02b2, rbserver, robee, rokinot, sach1r0, sashik_eth, simon135, slywaters

Awards

41.8495 USDC - $41.85

Labels

bug

G (Gas Optimization)

sponsor acknowledged

External Links

Link to GitHub issue

1. state variables only set in the constructor should be declared immutable

avoids a gsset (20000 gas)

implementation should be immutable.

2. state variables should be cached in stack variables rather than re-reading them from storage

3. x = x + y is cheaper than x += y

4. better to use `++i` than `i++`

5. use custom errors rather than revert()/require() strings to save deployment gas

https://blog.soliditylang.org/2021/04/21/custom-errors/

Fractional v2 contest - ReyAdmirado's results

A collective ownership platform for NFTs on Ethereum.

General Information

Findings Distribution

Researcher Performance

External Links

Findings Information

Awards

Labels

External Links

Findings Information

Awards

Labels

External Links

1. state variables only set in the constructor should be declared immutable

2. state variables should be cached in stack variables rather than re-reading them from storage

3. x = x + y is cheaper than x += y

4. better to use `++i` than `i++`

5. use custom errors rather than revert()/require() strings to save deployment gas

6. expressions for constant values such as a call to keccak256(), should use immutable rather than constant

7. `<array>.length` should not be looked up in every loop of a for-loop

8.it costs more gas to initialize variables to zero than to let the default of zero be applied

9. require()/revert() strings longer than 32 bytes cost extra gas

Fractional v2 contest - ReyAdmirado's results

A collective ownership platform for NFTs on Ethereum.

General Information

Findings Distribution

Researcher Performance

External Links

[Q-82] QA Report - $61.94

Findings Information

Awards

Labels

External Links

[G-61] Gas Report - $41.85

Findings Information

Awards

Labels

External Links

1. state variables only set in the constructor should be declared immutable

2. state variables should be cached in stack variables rather than re-reading them from storage

3. x = x + y is cheaper than x += y

4. better to use ++i than i++

5. use custom errors rather than revert()/require() strings to save deployment gas

6. expressions for constant values such as a call to keccak256(), should use immutable rather than constant

7. <array>.length should not be looked up in every loop of a for-loop

8.it costs more gas to initialize variables to zero than to let the default of zero be applied

9. require()/revert() strings longer than 32 bytes cost extra gas

4. better to use `++i` than `i++`

7. `<array>.length` should not be looked up in every loop of a for-loop