Fractional v2 contest - rokinot's results

Non-critical findings

Unused constant variable ERC1155_BATCH_TRANSFER_CALLDATA_BASE_SIZE in Transfer.sol

L#84

Consider adding constant values for these assembly hex numbers in the contract instead of using magic numbers, as it is used in other parts of the project and improves readability.

Odd number checks using & 0x1 == 1 are more efficient than % 2 == 1

#L91

Also worth nothing this is already done in the same contract at #L135

!= comparisons for array lengths are more efficient than < comparisons. This optimization can be done for loops where the iterator i will not increment with values higher than 1.

#L78 #L496 #L64 #L83 #L107 #L130 #L51 #L110 #L147 #L19

Use custom errors rather than require()/revert() for decreased deployment costs.

#L62 #L78

Division by 2 should use bit shifting i >> 1, as the opcodes for SHR costs 3 gas vs MUL which costs 5 gas.

#L100 #L142 #L136