Holograph contest - Tagir2003's results

QA REPORT

[LOW] For the following functions, add timelock

Proof of concept:

• Holograph.sol#L128
• HolographRegistry.sol#L237

[NON CRITICAL] Use of magic numbers in the following locations

Proof of concept:

• PA1D.sol#L552
• PA1D.sol#L394

[NON CRITICAL] The following functions may not be payable

Proof of concept:

• HolographOperatorProxy.sol#L46
• HolographRegistryProxy.sol#L145

GAS REPORT

[GAS] Cache the following arrays size before the loop

Proof of concept:

• HolographRegistry.sol#L174
• HolographERC20.sol#L563

[GAS] Caching msg.sender is unnecessary

Proof of concept:

• HolographRegistry.sol#L169
• HolographERC20.sol#L125

[GAS] The following require statements could be split into multiple require statements to save gas

Proof of concept:

• HolographTreasuryProxy.sol#L26
• HolographERC721.sol#L463

[GAS] Consider using custom errors

You can utilize customized errors in require statements to save gas.

Proof of concept:

• HolographGenesis.sol#L129
• HolographFactory.sol#L120